public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Jean-Loïc Charroud" <lagiraudiere+linux@free.fr>
Cc: Takashi Iwai <tiwai@suse.de>,
	Stefan Binding <sbinding@opensource.cirrus.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Richard Fitzgerald <rf@opensource.cirrus.com>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	patches@opensource.cirrus.com
Subject: Re: [PATCH v2] ALSA: hda/realtek: cs35l41: Fix internal speaker support for ASUS UM3402 with missing DSD
Date: Wed, 07 Feb 2024 14:42:22 +0100	[thread overview]
Message-ID: <87o7cs5r29.wl-tiwai@suse.de> (raw)
In-Reply-To: <726559913.576332068.1707239153891.JavaMail.zimbra@free.fr>

On Tue, 06 Feb 2024 18:05:53 +0100,
Jean-Loïc Charroud wrote:
> 
> Fix device ID for "ASUS UM3402" and "ASUS UM6702RA/RC".
> Add _DSD values for "ASUS UM3402" to cs35l41_config_table[].

So far, so good, but...

> Reorder alc269_fixup_tbl[] by device id and remove duplicate QUIRK
> entry for device {0x1043, 0x1f62, "ASUS UX7602ZM"}.

Don't mix up multiple things in a single patch.
The sort of the existing entries has little to do with your change.
Leave it to another patch instead (with Fixes tag for the
corresponding commit, too).


thanks,

Takashi

  reply	other threads:[~2024-02-07 13:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-06 17:05 [PATCH v2] ALSA: hda/realtek: cs35l41: Fix internal speaker support for ASUS UM3402 with missing DSD Jean-Loïc Charroud
2024-02-07 13:42 ` Takashi Iwai [this message]
2024-02-07 14:30   ` Jean-Loïc Charroud
2024-02-07 15:10     ` Takashi Iwai
2024-02-07 16:45       ` Jean-Loïc Charroud
2024-02-07 16:51       ` [PATCH] ALSA: hda/realtek: cs35l41: Fix device ID / model name Jean-Loïc Charroud
2024-02-07 17:10         ` Takashi Iwai
2024-02-07 18:05           ` Jean-Loïc Charroud
2024-02-07 17:48       ` [PATCH v2] ALSA: hda/realtek: cs35l41: Fix internal speaker support for ASUS UM3402 with missing DSD Jean-Loïc Charroud
2024-02-07 18:13         ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7cs5r29.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=lagiraudiere+linux@free.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    --cc=rf@opensource.cirrus.com \
    --cc=sbinding@opensource.cirrus.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox