From: Thomas Gleixner <tglx@linutronix.de>
To: Haoran Liu <liuhaoran14@163.com>, tsbogend@alpha.franken.de
Cc: fancer.lancer@gmail.com, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org, Haoran Liu <liuhaoran14@163.com>
Subject: Re: [PATCH] [irqchip] mips-cpu: Add error handling in mips_cpu_register_ipi_domain
Date: Fri, 08 Dec 2023 15:13:19 +0100 [thread overview]
Message-ID: <87o7f0sry8.ffs@tglx> (raw)
In-Reply-To: <20231130040642.36133-1-liuhaoran14@163.com>
On Wed, Nov 29 2023 at 20:06, Haoran Liu wrote:
The subject line:
https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#patch-subject
> This patch enhances the mips_cpu_register_ipi_domain function in
# git grep 'This patch' Documentation/process/
> drivers/irqchip/irq-mips-cpu.c by adding error handling for the
> kzalloc
The file name is irrelevant. Please read and follow:
https://www.kernel.org/doc/html/latest/process/maintainer-tip.html
> call. Previously, the function lacked proper handling for kzalloc
> failures, which could lead to potential null pointer dereference issues
> under low memory conditions.
The value of this "enhancement" is dubious. if that kzalloc() fails then
any subsequent allocation will fail too and the machine will crash
anyway.
prev parent reply other threads:[~2023-12-08 14:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 4:06 [PATCH] [irqchip] mips-cpu: Add error handling in mips_cpu_register_ipi_domain Haoran Liu
2023-12-08 14:13 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7f0sry8.ffs@tglx \
--to=tglx@linutronix.de \
--cc=fancer.lancer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=liuhaoran14@163.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox