From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0213C4332F for ; Sat, 4 Nov 2023 09:56:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231768AbjKDJ4r (ORCPT ); Sat, 4 Nov 2023 05:56:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229468AbjKDJ4p (ORCPT ); Sat, 4 Nov 2023 05:56:45 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E9881BC for ; Sat, 4 Nov 2023 02:56:43 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18455C433C8; Sat, 4 Nov 2023 09:56:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699091803; bh=yBRJ2Iik1AL9eX0LaHG2P5msyufN+rdyxQIPGaFUtDQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=U0JNmCY5l+j2AgNLP0oXIsaEkMmrGa1GmeSSRnPr+4Okqj8ecXqJ1IIQXLP89R6mv TmlXhNDGA91hBQQzcsV1bdqgRcpor8SHQnFtClQ97r3465ezgZj8FID8svzrLrXRLG /873kSYa2Mzp0GBWIhobVylGuj3aVfEPpA3ollwFVZxyCR5U5huVuRZx5FXnuRWk7G f30d+g5NatWOEtMNxpIGOR9OqGSk7GXxPzDCpuqUMJdO8DbIW2d6Dp93bkihx4NzXS Xh3x4siBsUKVaoFdPkPxAj/QUdEGYj21RUJP474pP0ggB2db/RjCL8t6QE6u7GiBl7 UqTHW1tGG0rOg== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qzDOS-00AHAI-IU; Sat, 04 Nov 2023 09:56:40 +0000 Date: Sat, 04 Nov 2023 09:56:40 +0000 Message-ID: <87o7g96duv.wl-maz@kernel.org> From: Marc Zyngier To: Fang Xiang Cc: , , Subject: Re: [PATCH v4] irqchip/gic-v3-its: Flush ITS tables before writing GITS_BASER registers in non-coherent GIC designs. In-Reply-To: <20231030083256.4345-1-fangxiang3@xiaomi.com> References: <20231030083256.4345-1-fangxiang3@xiaomi.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: fangxiang3@xiaomi.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 30 Oct 2023 08:32:56 +0000, Fang Xiang wrote: > > In non-coherent GIC design, ITS tables should be clean and flushed > to the PoV of the ITS before writing GITS_BASER registers, otherwise > the ITS would read dirty tables and lead to UNPREDICTABLE behaviors. > > The ITS always got clean tables in initialization with this fix, by > observing the signals from GIC. > > Furthermore, hoist the quirked non-shareable attributes earlier to > save effort in tables setup. > > Suggested-by: Marc Zyngier > Signed-off-by: Fang Xiang > Tested-by: Fang Xiang Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.