From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9AF8EE6452 for ; Fri, 15 Sep 2023 10:27:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232834AbjIOK1z (ORCPT ); Fri, 15 Sep 2023 06:27:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232986AbjIOIcR (ORCPT ); Fri, 15 Sep 2023 04:32:17 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58A4A2D50 for ; Fri, 15 Sep 2023 01:31:23 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DC06A2187D; Fri, 15 Sep 2023 08:31:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1694766681; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q2Beeu5CPtfOOLJTu6GgdOUwpcTJvByrQgKRtH+jqas=; b=rwOdIsx5ZAji3I0kvtYRyEICeSjZDJV7AVZfAxDjDdpOAcxgxt7gzfFquV4VyKf6b66TSW 4h0H0MXSuhcNz4Hze9nvbFE7pW+7IwOvh/kzd7vfuTQszdxZBkjTttVSnSQBHeq+C273iJ yM+gkJkCViqw3tRNMg3KI78JHlMJXtM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1694766681; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q2Beeu5CPtfOOLJTu6GgdOUwpcTJvByrQgKRtH+jqas=; b=TL/0dtrAOQ0daQwqQtmkkm+RqbpF2gHaH80OM/UQymRDE9BlRwlq2dFQIFRInUtCGXGzuh 6JP9BH3KnlKnSiBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A05491358A; Fri, 15 Sep 2023 08:31:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id GnXmJVkWBGVuQwAAMHmgww (envelope-from ); Fri, 15 Sep 2023 08:31:21 +0000 Date: Fri, 15 Sep 2023 10:31:21 +0200 Message-ID: <87o7i3x2g6.wl-tiwai@suse.de> From: Takashi Iwai To: Richard Fitzgerald Cc: , , , Subject: Re: [PATCH v2] ALSA: hda: cs35l56: Fix missing RESET GPIO if _SUB is missing In-Reply-To: <20230914152525.20829-1-rf@opensource.cirrus.com> References: <20230914152525.20829-1-rf@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Sep 2023 17:25:25 +0200, Richard Fitzgerald wrote: > > In cs35l56_hda_read_acpi() do not return if ACPI _SUB is missing. > > A missing _SUB means that the driver cannot load a system-specific > firmware, because the firmware is identified by the _SUB. But it can > fallback to a generic firmware. Unfortunately this was being handled > by immediately returning 0, which would skip the remaining ACPI > configuration in cs35l56_hda_read_acpi() and so it would not get the > RESET GPIO. > > Signed-off-by: Richard Fitzgerald > Fixes: 73cfbfa9caea ("ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier") Thanks, applied now. Takashi