From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0224FEE498D for ; Fri, 18 Aug 2023 18:29:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379438AbjHRS3K (ORCPT ); Fri, 18 Aug 2023 14:29:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357051AbjHRS2j (ORCPT ); Fri, 18 Aug 2023 14:28:39 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81C65BF for ; Fri, 18 Aug 2023 11:28:38 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 184971F74B; Fri, 18 Aug 2023 18:28:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1692383317; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uSIOC01SNEMHZE/GJDc/41dzaL6uTedaZsYjL6U2Nt8=; b=xOXZ6EL9L/KQILtgnFXrXLJ7nr3scvjXdaYoMrmfdqP8GGRz3IYuXCY/Mf0xpq97nWnV3a cwBQj5mFC0KJJfgMEtQHvQJoTJ53dhGwiTU1864Vwt3AYlhc560umDsrtmV1ZaXVJ3a3ZF UH/5J9tp4123UCzgPJhg/CvjEsTLK9Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1692383317; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uSIOC01SNEMHZE/GJDc/41dzaL6uTedaZsYjL6U2Nt8=; b=q7K5BQDSbkG+fmkEIz0IlVEBdBuHGd09xpgSEleIQHV2wcbZg55/ztQ4D1mYuqXbVDLLez YWjY9RKWy40TT7CQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B3B0313441; Fri, 18 Aug 2023 18:28:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id M/PyKlS432RhMgAAMHmgww (envelope-from ); Fri, 18 Aug 2023 18:28:36 +0000 Date: Fri, 18 Aug 2023 20:28:36 +0200 Message-ID: <87o7j4gq7f.wl-tiwai@suse.de> From: Takashi Iwai To: Pierre-Louis Bossart Cc: Shenghao Ding , robh+dt@kernel.org, lgirdwood@gmail.com, perex@perex.cz, kevin-lu@ti.com, 13916275206@139.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, liam.r.girdwood@intel.com, mengdong.lin@intel.com, baojun.xu@ti.com, thomas.gfeller@q-drop.com, peeyush@ti.com, navada@ti.com, broonie@kernel.org, gentuser@gmail.com Subject: Re: [PATCH v4 1/2] ALSA: hda/tas2781: Add tas2781 HDA driver In-Reply-To: <87r0o0gssk.wl-tiwai@suse.de> References: <20230818085836.1442-1-shenghao-ding@ti.com> <87pm3kk63a.wl-tiwai@suse.de> <72960354-3f69-e2fa-e7b0-dc8b61ca4940@linux.intel.com> <87r0o0gssk.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 18 Aug 2023 19:32:43 +0200, Takashi Iwai wrote: > > On Fri, 18 Aug 2023 18:36:16 +0200, > Pierre-Louis Bossart wrote: > > > > > > > > On 8/18/23 05:17, Takashi Iwai wrote: > > > On Fri, 18 Aug 2023 10:58:35 +0200, > > > Shenghao Ding wrote: > > >> > > >> Integrate tas2781 configs for Lenovo Laptops. All of the tas2781s in the > > >> laptop will be aggregated as one audio device. The code support realtek > > >> as the primary codec. Rename "struct cs35l41_dev_name" to > > >> "struct scodec_dev_name" for all other side codecs instead of the certain > > >> one. > > >> > > >> Signed-off-by: Shenghao Ding > > > > > > Now I applied both patches to for-next branch. > > > > > > The patch 2 needed some minor adjustment in Kconfig to be applied to > > > the latest branch, but I resolved it locally. > > > > There are a number of issues I just reported, I guess they will have to > > be handled with a follow-up patch now? > > Yes, let's fix incrementally on the top. ... and since it's already merged, it means that everyone can submit patches for fixing issues there, and I'd happily apply fixes no matter who submitted them, as long as the fixes are correct ;) Takashi