From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7835EB64DA for ; Tue, 4 Jul 2023 08:16:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230326AbjGDIQq (ORCPT ); Tue, 4 Jul 2023 04:16:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230195AbjGDIQl (ORCPT ); Tue, 4 Jul 2023 04:16:41 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31756E52 for ; Tue, 4 Jul 2023 01:16:40 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CF886225A0; Tue, 4 Jul 2023 08:16:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1688458598; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FPBg6p9QylZ6LXwL7TvvMNJ95t3SM1oPEWDK0MHP+qk=; b=rfrgAHLrrecq/cG6+NsHPf0UHlh9zEBr5aPHwvIy5RVe7QWYZmYt3uJV7vHrkVAwYDKc2D qxvX41Lu6qKN1+r1wF+ch8INYqV5N9OVm93FhVvwE64zunlo4HIcqXv8CT/q1UK7qAdLJM 0ANUF8usKFTFo9B5SQe1Dpdwq7MEjag= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1688458598; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FPBg6p9QylZ6LXwL7TvvMNJ95t3SM1oPEWDK0MHP+qk=; b=zgMUnSPzMkS7ARahdYyIvfy9W954bZlpyFHkl4jpkfzi+iq7L/pp78K/HOnBTc6d6nKcgj mjhfKJjLdJ3UU3DA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9E3F71346D; Tue, 4 Jul 2023 08:16:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Gae5JWbVo2R8JwAAMHmgww (envelope-from ); Tue, 04 Jul 2023 08:16:38 +0000 Date: Tue, 04 Jul 2023 10:16:38 +0200 Message-ID: <87o7ks2is9.wl-tiwai@suse.de> From: Takashi Iwai To: Dan Carpenter Cc: oe-kbuild@lists.linux.dev, Takashi Sakamoto , lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Takashi Iwai Subject: Re: sound/firewire/amdtp-stream.c:1099 process_rx_packets() error: uninitialized symbol 'curr_cycle_time'. In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 03 Jul 2023 15:00:01 +0200, Dan Carpenter wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > head: b25f62ccb490680a8cee755ac4528909395e0711 > commit: fef4e61b0b765b6d22badcd5b6575b159e7d510a ALSA: firewire-lib: extend tracepoints event including CYCLE_TIME of 1394 OHCI > config: i386-randconfig-m021-20230701 (https://download.01.org/0day-ci/archive/20230701/202307011324.jFJ96dTo-lkp@intel.com/config) > compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 > reproduce: (https://download.01.org/0day-ci/archive/20230701/202307011324.jFJ96dTo-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Reported-by: Dan Carpenter > | Closes: https://lore.kernel.org/r/202307011324.jFJ96dTo-lkp@intel.com/ > > New smatch warnings: > sound/firewire/amdtp-stream.c:1099 process_rx_packets() error: uninitialized symbol 'curr_cycle_time'. > > Old smatch warnings: > sound/firewire/amdtp-stream.c:944 generate_tx_packet_descs() error: uninitialized symbol 'curr_cycle_time'. (snip) > The curr_cycle_time variable is only going to be used if trace_amdtp_packet_enabled() > is true. We would consider it a false positive if build_it_pkt_header() > is inlined but a bug if it's not. (Technically passing uninitialized > data is undefined behavior but if a function is inlined then it's not > "passing" anything). Yes, this is a false-positive, so no much worry needed. But it's hard for compiler / checker to know it, and I guess that simply initializing the variable would be the easiest workaround, after all. thanks, Takashi