From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id AB322C7EE29
	for <linux-kernel@archiver.kernel.org>; Sat, 10 Jun 2023 20:13:24 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230147AbjFJUNX (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Sat, 10 Jun 2023 16:13:23 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38750 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229483AbjFJUNU (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 10 Jun 2023 16:13:20 -0400
Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 455CA359D;
        Sat, 10 Jun 2023 13:13:19 -0700 (PDT)
From:   Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
        s=2020; t=1686427997;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=2FyW3Bj3MP4r2QbMriRspWC1T3TG2cIZbpm8o1sYXRk=;
        b=Bd6rcV9NAKZ2jF9T8IY/r60E4T8w90YHhU5xFpw/hpWHfXb8L6JiuDXY0t79Yll+2GT6qE
        xrQyfEHRFmUxuDwx1/hyEMammkYISdlkOp8umKeLO+o4AnucWOKnN3HM0OxQQL/XA0ywIy
        jHqvlI6q6CItsjeO85N9m0vwdlI0qw4BBxATVqzRnrzmnuXkZGICP3+ltYVrg+XNfQ8PH1
        ZntGRksKEHGrc3g3thOpY0E4eqXRzpz0bQI1NqI/3iDCzmd14sewUC7kzvRe7xLNc7k3EH
        LI7pUFpw5cBoVrnoMRc/G/yBYTw2YrVP6uWDa4mT9GS4MqLzrE6VkQ91ePn82w==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
        s=2020e; t=1686427997;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=2FyW3Bj3MP4r2QbMriRspWC1T3TG2cIZbpm8o1sYXRk=;
        b=bgPUpEic0mpyby3BGyAvEpiW4XSnGc6In+X8PMucBYAVIRaPTCmQlzaXQV9yZA55ZBey2P
        6Kr948u6T/TlPVBw==
To:     Michael Ellerman <mpe@ellerman.id.au>, linux-kernel@vger.kernel.org
Cc:     linuxppc-dev@lists.ozlabs.org, linux-arch@vger.kernel.org,
        ldufour@linux.ibm.com, bp@alien8.de, dave.hansen@linux.intel.com,
        mingo@redhat.com, x86@kernel.org
Subject: Re: [PATCH 6/9] cpu/SMT: Allow enabling partial SMT states via sysfs
In-Reply-To: <87r0qj84fr.ffs@tglx>
References: <20230524155630.794584-1-mpe@ellerman.id.au>
 <20230524155630.794584-6-mpe@ellerman.id.au> <87r0qj84fr.ffs@tglx>
Date:   Sat, 10 Jun 2023 22:13:17 +0200
Message-ID: <87o7ln849u.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Jun 10 2023 at 22:09, Thomas Gleixner wrote:

> On Thu, May 25 2023 at 01:56, Michael Ellerman wrote:
>> There is a hook which allows arch code to control how many threads per
>
> Can you please write out architecture in changelogs and comments?
>
> I know 'arch' is commonly used but while my brain parser tolerates
> 'arch_' prefixes it raises an exception on 'arch' in prose as 'arch' is
> a regular word with a completely different meaning. Changelogs and
> comments are not space constraint.
>
>> @@ -2505,20 +2505,38 @@ __store_smt_control(struct device *dev, struct device_attribute *attr,
>>  	if (cpu_smt_control == CPU_SMT_NOT_SUPPORTED)
>>  		return -ENODEV;
>>  
>> -	if (sysfs_streq(buf, "on"))
>> +	if (sysfs_streq(buf, "on")) {
>>  		ctrlval = CPU_SMT_ENABLED;
>> -	else if (sysfs_streq(buf, "off"))
>> +		num_threads = cpu_smt_max_threads;
>> +	} else if (sysfs_streq(buf, "off")) {
>>  		ctrlval = CPU_SMT_DISABLED;
>> -	else if (sysfs_streq(buf, "forceoff"))
>> +		num_threads = 1;
>> +	} else if (sysfs_streq(buf, "forceoff")) {
>>  		ctrlval = CPU_SMT_FORCE_DISABLED;
>> -	else
>> +		num_threads = 1;
>> +	} else if (kstrtoint(buf, 10, &num_threads) == 0) {
>> +		if (num_threads == 1)
>> +			ctrlval = CPU_SMT_DISABLED;
>> +		else if (num_threads > 1 && topology_smt_threads_supported(num_threads))

Why does this not simply check cpu_smt_max_threads?

		else if (num_threads > 1 && num_threads <= cpu_smt_max_threads)

cpu_smt_max_threads should have been established already, no?

Thanks,

        tglx