From: "Björn Töpel" <bjorn@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Palmer Dabbelt" <palmer@dabbelt.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-kernel@vger.kernel.org, "Björn Töpel" <bjorn@rivosinc.com>,
"Heiko Stuebner" <heiko@sntech.de>,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2 1/2] lib/test_string.c: Make definition less dense
Date: Tue, 28 Feb 2023 20:41:03 +0100 [thread overview]
Message-ID: <87o7pdfui8.fsf@all.your.base.are.belong.to.us> (raw)
In-Reply-To: <CAHp75VfK3RM+SP90d3nOXEobY81Xd_94tLL=Qt86mmdNwXaQpg@mail.gmail.com>
Andy Shevchenko <andy.shevchenko@gmail.com> writes:
> On Tue, Feb 28, 2023 at 8:42 PM Björn Töpel <bjorn@kernel.org> wrote:
>>
>> From: Björn Töpel <bjorn@rivosinc.com>
>>
>> Checkpatch seems to have trouble making sense of the situation when
>> struct definitions, variable definitions, and __initconst marking is
>> done in one go.
>>
>> Let's be nicer to checkpatch, and move the struct definition out,
>> which removes the error.
>
> Not that I'm against the patch, but how hard is it to fix the checkpatch?
Uhm, good one. I'll have a look (the .pl scared me off).
prev parent reply other threads:[~2023-02-28 19:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 18:42 [PATCH v2 1/2] lib/test_string.c: Make definition less dense Björn Töpel
2023-02-28 18:42 ` [PATCH v2 2/2] lib/test_string.c: Add strncmp() tests Björn Töpel
2023-02-28 19:03 ` [PATCH v2 1/2] lib/test_string.c: Make definition less dense Andy Shevchenko
2023-02-28 19:41 ` Björn Töpel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7pdfui8.fsf@all.your.base.are.belong.to.us \
--to=bjorn@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=bjorn@rivosinc.com \
--cc=heiko@sntech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox