From: Jonathan Corbet <corbet@lwn.net>
To: Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
David Vernet <void@manifault.com>
Cc: bpf@vger.kernel.org, ast@kernel.org, andrii@kernel.org,
martin.lau@linux.dev, song@kernel.org, yhs@meta.com,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com,
haoluo@google.com, jolsa@kernel.org,
linux-kernel@vger.kernel.org, kernel-team@meta.com,
memxor@gmail.com
Subject: Re: [PATCH bpf-next v2 3/3] bpf: Use BPF_KFUNC macro at all kfunc definitions
Date: Mon, 23 Jan 2023 14:00:17 -0700 [thread overview]
Message-ID: <87o7qphspq.fsf@meer.lwn.net> (raw)
In-Reply-To: <ebff2166-8a70-af62-b859-6b5c6b008b36@iogearbox.net>
Daniel Borkmann <daniel@iogearbox.net> writes:
> Did you look into making this similar to the EXPORT_SYMBOL() infra? If possible
> that would look much more natural to developers, e.g. :
>
> struct nf_conn *
> bpf_skb_ct_lookup(struct __sk_buff *skb_ctx, struct bpf_sock_tuple *bpf_tuple,
> u32 tuple__sz, struct bpf_ct_opts *opts, u32 opts__sz)
> {
> [...]
> }
>
> EXPORT_BPF_KFUNC(bpf_skb_ct_lookup);
That was my question too; it's a similar functionality that would be
nice to express in a similar way. Even better, if possible, might be to
fold it into BTF_ID_FLAGS, which I might then rename to EXPORT_KFUNC()
or some such ... :)
Thanks,
jon
next prev parent reply other threads:[~2023-01-23 21:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 17:15 [PATCH bpf-next v2 0/3] Add BPF_KFUNC macro for kfunc definitions David Vernet
2023-01-23 17:15 ` [PATCH bpf-next v2 1/3] bpf: Add BPF_KFUNC macro for defining kfuncs David Vernet
2023-01-23 17:15 ` [PATCH bpf-next v2 2/3] bpf: Document usage of the new BPF_KFUNC macro David Vernet
2023-01-23 17:15 ` [PATCH bpf-next v2 3/3] bpf: Use BPF_KFUNC macro at all kfunc definitions David Vernet
2023-01-23 18:33 ` Alexei Starovoitov
2023-01-23 18:48 ` David Vernet
2023-01-23 18:54 ` Alexei Starovoitov
2023-01-23 19:01 ` David Vernet
2023-01-23 19:04 ` Daniel Borkmann
2023-01-23 21:00 ` Jonathan Corbet [this message]
2023-01-24 0:54 ` David Vernet
2023-01-24 14:50 ` Jonathan Corbet
2023-01-24 16:20 ` David Vernet
2023-01-31 15:15 ` Alan Maguire
2023-01-31 15:44 ` David Vernet
2023-01-31 17:30 ` Alexei Starovoitov
2023-01-23 19:01 ` kernel test robot
2023-01-23 19:12 ` kernel test robot
2023-01-24 7:15 ` Christoph Hellwig
2023-01-24 14:15 ` David Vernet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7qphspq.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kernel-team@meta.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=void@manifault.com \
--cc=yhs@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox