Re: [PATCH] powerpc: clean up binutils version check

[Michael Ellerman <mpe@ellerman.id.au>]

Christophe Leroy <christophe.leroy@csgroup.eu> writes:
> Le 27/08/2022 à 20:03, Masahiro Yamada a écrit :
>> On Sun, Aug 28, 2022 at 2:37 AM Christophe Leroy
>> <christophe.leroy@csgroup.eu> wrote:
>>> Le 27/08/2022 à 18:40, Masahiro Yamada a écrit :
>>>> The checkbin in arch/powerpc/Makefile errors out if ld <= 2.24.
>>>> So, the requirement on PPC is binutils >= 2.25. It is cleaner to
>>>> specify it in scripts/min-tool-version.sh. If binutils < 2.25 is
>>>> used, the toolchain check will fail in the Kconfig stage going
>>>> forward.
>>>>
>>>> Since binutils >= 2.25 is already required, another version test
>>>> for --save-restore-funcs on PPC64 is always met.
...
>>>> diff --git a/scripts/min-tool-version.sh b/scripts/min-tool-version.sh
>>>> index 250925aab101..7df9f2150ea1 100755
>>>> --- a/scripts/min-tool-version.sh
>>>> +++ b/scripts/min-tool-version.sh
>>>> @@ -14,7 +14,13 @@ fi
>>>>
>>>>    case "$1" in
>>>>    binutils)
>>>> -     echo 2.23.0
>>>> +     if [ "$SRCARCH" = powerpc ]; then
>>>
>>> Isn't this limitation only for ppc64le ?
>>>
>>> Refer commit 60e065f70bdb ("powerpc: Reject binutils 2.24 when building
>>> little endian")
>> 
>> I do not see any CONFIG check in the current checkbin.
>> 
>> Refer commit a3ad84da0760 ("powerpc/toc: Future proof
>> kernel toc")
>
> That's odd. There is no toc on PPC32.

I think that's just a bug in a3ad84da0760.

But that means we inadvertantly dropped support for 2.24 about 8 months
ago, and no one noticed.

Let's see what the responses are to Nick's proposal to increase the
minimum to 2.25.1.

cheers