From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Chung-Chiang Cheng <shepjeng@gmail.com>
Cc: Chung-Chiang Cheng <cccheng@synology.com>,
linux-kernel@vger.kernel.org, kernel@cccheng.net
Subject: Re: [PATCH v3 3/3] fat: report creation time in statx
Date: Fri, 22 Apr 2022 21:06:42 +0900 [thread overview]
Message-ID: <87o80tpbjh.fsf@mail.parknet.co.jp> (raw)
In-Reply-To: <CAHuHWt=xYOBhRp_KJrSF5-xDBW+x_O4gnQSsX2M5u2D8zSXwTg@mail.gmail.com> (Chung-Chiang Cheng's message of "Fri, 22 Apr 2022 16:20:06 +0800")
Chung-Chiang Cheng <shepjeng@gmail.com> writes:
>
> I also have a question. If msdos doesn't support create-time, why does the
> original fat_truncate_time() truncate it to a 2-sec granularity?
>
> if (flags & S_CTIME) {
> if (sbi->options.isvfat)
> inode->i_ctime = fat_timespec64_trunc_10ms(*now);
> else
> inode->i_ctime = fat_timespec64_trunc_2secs(*now);
> }
>
> This logic was introduced in 6bb885ecd746 (fat: add functions to update
> and truncate timestamps appropriately"), and seems not for change-time.
> Should I remove it?
Hm, not sure.
However, ctime/atime is not stored into backing storage in
__fat_write_inode() and loaded if !isvfat (if I'm not missing
something). So I think we don't need it for creation time.
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
prev parent reply other threads:[~2022-04-22 12:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 9:45 [PATCH v3 1/3] fat: split fat_truncate_time() into separate functions Chung-Chiang Cheng
2022-04-15 9:45 ` [PATCH v3 2/3] fat: make ctime and mtime identical explicitly Chung-Chiang Cheng
2022-04-15 13:28 ` OGAWA Hirofumi
2022-04-22 8:24 ` Chung-Chiang Cheng
2022-04-15 9:45 ` [PATCH v3 3/3] fat: report creation time in statx Chung-Chiang Cheng
2022-04-15 13:17 ` OGAWA Hirofumi
2022-04-22 8:20 ` Chung-Chiang Cheng
2022-04-22 12:06 ` OGAWA Hirofumi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o80tpbjh.fsf@mail.parknet.co.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=cccheng@synology.com \
--cc=kernel@cccheng.net \
--cc=linux-kernel@vger.kernel.org \
--cc=shepjeng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox