public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Chris Kennelly <ckennelly@google.com>,
	Paul Turner <pjt@google.com>, Peter Oskolkov <posk@posk.io>,
	libc-alpha <libc-alpha@sourceware.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: Aligning tcmalloc with glibc 2.35 rseq ABI
Date: Wed, 02 Feb 2022 16:01:15 +0100	[thread overview]
Message-ID: <87o83pxqh0.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <770517862.27112.1643807335312.JavaMail.zimbra@efficios.com> (Mathieu Desnoyers's message of "Wed, 2 Feb 2022 08:08:55 -0500 (EST)")

* Mathieu Desnoyers:

> More to the point: is ptrdiff_t the correct type here ? I think so.
> Do we want to revert the ABI and wait another 6 months before we
> bring back rseq into glibc just for this ? I'm not sure this limitation
> justifies it.
>
> So if there is a quick way to fix that before the official 2.35 release,
> I'm all for it, otherwise I cannot say that __rseq_offset being an "int"
> rather than a "ptrdiff_t" will make much real-life difference (unless
> I'm proven wrong). But we will be stuck with this quirk forever.

I'm going to post a patch.  It's fairly small.

Thanks,
Florian


  reply	other threads:[~2022-02-02 15:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-01 14:58 Aligning tcmalloc with glibc 2.35 rseq ABI Mathieu Desnoyers
2022-02-01 20:33 ` Chris Kennelly
     [not found]   ` <87mtja1fuz.fsf@oldenburg.str.redhat.com>
     [not found]     ` <875ypx1x0d.fsf@oldenburg.str.redhat.com>
2022-02-02 11:36       ` Mathieu Desnoyers
2022-02-02 13:08         ` Mathieu Desnoyers
2022-02-02 15:01           ` Florian Weimer [this message]
2022-02-02 17:31             ` Carlos O'Donell
2022-02-02 22:28               ` Carlos O'Donell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o83pxqh0.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=ckennelly@google.com \
    --cc=libc-alpha@sourceware.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=peterz@infradead.org \
    --cc=pjt@google.com \
    --cc=posk@posk.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox