From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA080C4332F for ; Wed, 15 Sep 2021 00:23:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8CA2B61214 for ; Wed, 15 Sep 2021 00:23:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230374AbhIOAYq (ORCPT ); Tue, 14 Sep 2021 20:24:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229657AbhIOAYp (ORCPT ); Tue, 14 Sep 2021 20:24:45 -0400 Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A5D6C061574; Tue, 14 Sep 2021 17:23:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1631665405; bh=Pliqrcvr6CmlpuzEgkusFjzlu2wuAo+oNPelgwZk/tI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=TPy4x0c0qB00Uky/okfi0agfYTTirGCIOxGnyL3Z2WJjcy9Ij+y6eYt34V0foPR/O o1okl98XSAlBWoLSjBK2ST30QS4MIAlF6Q5jA9WbJd+t/pYlgoXvxAw0bJWuqYJ3kd 7a7a6bYzwZZ6/qCNoSAmjasAfhIO+tm/yfC0Qr4vHTgZfWFSMgRJZ0XA3P/TYxv3W8 HAXDqW2k6pmwvEaigI491dok7/GBd2trlcrP8o0JI2Q9R8YjbcSTnLHIZiytZzNpto aHqxor2QYwZ9tGiIR0+zkTxf7ARZwTpGwCyhJhFhBNQsj7LzgLsiKQ4LnRpQ+coT+7 P6bVDxR2ZyoQQ== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4H8LXr70S6z9s5R; Wed, 15 Sep 2021 10:23:24 +1000 (AEST) From: Michael Ellerman To: Bjorn Helgaas , Niklas Schnelle Cc: Bjorn Helgaas , Benjamin Herrenschmidt , Oliver O'Halloran , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 1/1] powerpc: Drop superfluous pci_dev_is_added() calls In-Reply-To: <20210914193130.GA1447657@bjorn-Precision-5520> References: <20210914193130.GA1447657@bjorn-Precision-5520> Date: Wed, 15 Sep 2021 10:23:22 +1000 Message-ID: <87o88uk7ph.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Bjorn Helgaas writes: > On Fri, Sep 10, 2021 at 04:19:40PM +0200, Niklas Schnelle wrote: >> On powerpc, pci_dev_is_added() is called as part of SR-IOV fixups >> that are done under pcibios_add_device() which in turn is only called in >> pci_device_add() whih is called when a PCI device is scanned. >> >> Now pci_dev_assign_added() is called in pci_bus_add_device() which is >> only called after scanning the device. Thus pci_dev_is_added() is always >> false and can be dropped. >> >> Signed-off-by: Niklas Schnelle > > Reviewed-by: Bjorn Helgaas > > This doesn't touch the PCI core, so maybe makes sense for you to take > it, Michael? But let me know if you think otherwise. Yeah I'm happy to take it, thanks. cheers