From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64D5FC48BE8 for ; Tue, 15 Jun 2021 09:48:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 46F6E61446 for ; Tue, 15 Jun 2021 09:48:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231458AbhFOJui (ORCPT ); Tue, 15 Jun 2021 05:50:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:58918 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231287AbhFOJug (ORCPT ); Tue, 15 Jun 2021 05:50:36 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0A8906143E; Tue, 15 Jun 2021 09:48:32 +0000 (UTC) Received: from [185.219.108.64] (helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lt5gL-007eHZ-0u; Tue, 15 Jun 2021 10:48:29 +0100 Date: Tue, 15 Jun 2021 10:48:28 +0100 Message-ID: <87o8c7ihlf.wl-maz@kernel.org> From: Marc Zyngier To: Yanan Wang Cc: James Morse , Alexandru Elisei , Eric Auger , Catalin Marinas , Will Deacon , , , , , Subject: Re: [PATCH] KVM: arm64: Trival coding style fixes for all vgic-related files In-Reply-To: <20210615035019.35808-1-wangyanan55@huawei.com> References: <20210615035019.35808-1-wangyanan55@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: wangyanan55@huawei.com, james.morse@arm.com, alexandru.elisei@arm.com, eric.auger@redhat.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, yuzenghui@huawei.com, wanghaibin.wang@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 15 Jun 2021 04:50:19 +0100, Yanan Wang wrote: > > These fixes introduce no functional change but just adjustment about > coding style issues for ARM64 vgic code. They mainly include identation > fix of function parameters/arguments, identation fix of structure > initialization, identation fix of comment, also the deletion of some > superfluous space lines. Please don't. This sort of patches bring little value, and make the backporting of important fixes more difficult because of pointless context change. Fixing these cosmetic details is fine when you are modifying the code. But as a standalone patch, this brings more pain than benefit. Thanks, M. -- Without deviation from the norm, progress is not possible.