From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Shuah Khan <skhan@linuxfoundation.org>,
peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
mark.rutland@arm.com, jolsa@redhat.com, namhyung@kernel.org
Cc: Shuah Khan <skhan@linuxfoundation.org>,
linux-kernel@vger.kernel.org, alexander.shishkin@linux.intel.com
Subject: Re: [PATCH] kernel: events: Use scnprintf() in show_pmu_*() instead of snprintf()
Date: Wed, 09 Sep 2020 09:45:15 +0300 [thread overview]
Message-ID: <87o8mfxxc4.fsf@ashishki-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20200901234930.359126-1-skhan@linuxfoundation.org>
Shuah Khan <skhan@linuxfoundation.org> writes:
> Since snprintf() returns would-be-output size instead of the actual
> output size, replace it with scnprintf(), so the nr_addr_filters_show(),
> type_show(), and perf_event_mux_interval_ms_show() routines return the
> actual size.
Well, firstly they should just be sprintf()s, and secondly, I wouldn't
worry about it, because [0].
[0] https://marc.info/?l=linux-kernel&m=159874491103969&w=2
Regards,
--
Alex
next prev parent reply other threads:[~2020-09-09 6:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 23:49 [PATCH] kernel: events: Use scnprintf() in show_pmu_*() instead of snprintf() Shuah Khan
2020-09-01 23:49 ` [PATCH] kernel: Use scnprintf() in show_smt_*() " Shuah Khan
2020-09-10 11:15 ` Qais Yousef
2020-09-09 6:45 ` Alexander Shishkin [this message]
2020-09-09 16:19 ` [PATCH] kernel: events: Use scnprintf() in show_pmu_*() " Shuah Khan
2020-09-09 17:27 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8mfxxc4.fsf@ashishki-desk.ger.corp.intel.com \
--to=alexander.shishkin@linux.intel.com \
--cc=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox