* [PATCH] drm: dpcd: Print more useful information during error @ 2020-04-09 19:52 Aurabindo Pillai 2020-04-14 11:03 ` Jani Nikula 0 siblings, 1 reply; 3+ messages in thread From: Aurabindo Pillai @ 2020-04-09 19:52 UTC (permalink / raw) To: maarten.lankhorst, mripard, airlied, daniel; +Cc: dri-devel, linux-kernel When DPCD access errors occur, knowing the register and request associated with the error helps debugging, so print the details in the debug message. Signed-off-by: Aurabindo Pillai <mail@aurabindo.in> --- drivers/gpu/drm/drm_dp_helper.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index a5364b519..545606aac 100644 --- a/drivers/gpu/drm/drm_dp_helper.c +++ b/drivers/gpu/drm/drm_dp_helper.c @@ -257,7 +257,9 @@ static int drm_dp_dpcd_access(struct drm_dp_aux *aux, u8 request, err = ret; } - DRM_DEBUG_KMS("Too many retries, giving up. First error: %d\n", err); + DRM_DEBUG_KMS("dpcd: Too many retries, giving up. First error: %d\t" + "address: %x\trequest: %x\t size:%zu\n", + err, msg.address, msg.request, msg.size); ret = err; unlock: -- 2.26.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm: dpcd: Print more useful information during error 2020-04-09 19:52 [PATCH] drm: dpcd: Print more useful information during error Aurabindo Pillai @ 2020-04-14 11:03 ` Jani Nikula 2020-04-16 1:44 ` Aurabindo Pillai 0 siblings, 1 reply; 3+ messages in thread From: Jani Nikula @ 2020-04-14 11:03 UTC (permalink / raw) To: Aurabindo Pillai, maarten.lankhorst, mripard, airlied, daniel Cc: linux-kernel, dri-devel On Thu, 09 Apr 2020, Aurabindo Pillai <mail@aurabindo.in> wrote: > When DPCD access errors occur, knowing the register and request > associated with the error helps debugging, so print the > details in the debug message. > > Signed-off-by: Aurabindo Pillai <mail@aurabindo.in> > --- > drivers/gpu/drm/drm_dp_helper.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c > index a5364b519..545606aac 100644 > --- a/drivers/gpu/drm/drm_dp_helper.c > +++ b/drivers/gpu/drm/drm_dp_helper.c > @@ -257,7 +257,9 @@ static int drm_dp_dpcd_access(struct drm_dp_aux *aux, u8 request, > err = ret; > } > > - DRM_DEBUG_KMS("Too many retries, giving up. First error: %d\n", err); > + DRM_DEBUG_KMS("dpcd: Too many retries, giving up. First error: %d\t" > + "address: %x\trequest: %x\t size:%zu\n", > + err, msg.address, msg.request, msg.size); Nitpicks, please don't add tabs, maybe use commas instead, and please add 0x in front of hex. BR, Jani. > ret = err; > > unlock: -- Jani Nikula, Intel Open Source Graphics Center ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm: dpcd: Print more useful information during error 2020-04-14 11:03 ` Jani Nikula @ 2020-04-16 1:44 ` Aurabindo Pillai 0 siblings, 0 replies; 3+ messages in thread From: Aurabindo Pillai @ 2020-04-16 1:44 UTC (permalink / raw) To: Jani Nikula Cc: maarten.lankhorst, mripard, David Airlie, Daniel Vetter, linux-kernel, dri-devel When DPCD access errors occur, knowing the register and request associated with the error helps debugging, so print the details in the debug message. Signed-off-by: Aurabindo Pillai <mail@aurabindo.in> --- drivers/gpu/drm/drm_dp_helper.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index c6fbe6e6b..8aafc01f5 100644 --- a/drivers/gpu/drm/drm_dp_helper.c +++ b/drivers/gpu/drm/drm_dp_helper.c @@ -257,7 +257,9 @@ static int drm_dp_dpcd_access(struct drm_dp_aux *aux, u8 request, err = ret; } - DRM_DEBUG_KMS("Too many retries, giving up. First error: %d\n", err); + DRM_DEBUG_KMS("dpcd: Too many retries, giving up. First error: %d," + " address: 0x%x, request: 0x%x, size:%zu\n", + err, msg.address, msg.request, msg.size); ret = err; unlock: -- 2.26.0 On Tue, Apr 14, 2020 at 7:04 AM Jani Nikula <jani.nikula@linux.intel.com> wrote: > > On Thu, 09 Apr 2020, Aurabindo Pillai <mail@aurabindo.in> wrote: > > When DPCD access errors occur, knowing the register and request > > associated with the error helps debugging, so print the > > details in the debug message. > > > > Signed-off-by: Aurabindo Pillai <mail@aurabindo.in> > > --- > > drivers/gpu/drm/drm_dp_helper.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c > > index a5364b519..545606aac 100644 > > --- a/drivers/gpu/drm/drm_dp_helper.c > > +++ b/drivers/gpu/drm/drm_dp_helper.c > > @@ -257,7 +257,9 @@ static int drm_dp_dpcd_access(struct drm_dp_aux *aux, u8 request, > > err = ret; > > } > > > > - DRM_DEBUG_KMS("Too many retries, giving up. First error: %d\n", err); > > + DRM_DEBUG_KMS("dpcd: Too many retries, giving up. First error: %d\t" > > + "address: %x\trequest: %x\t size:%zu\n", > > + err, msg.address, msg.request, msg.size); > > Nitpicks, please don't add tabs, maybe use commas instead, and please > add 0x in front of hex. > > BR, > Jani. > > > > ret = err; > > > > unlock: > > -- > Jani Nikula, Intel Open Source Graphics Center -- Thanks and Regards, Aurabindo J Pillai https://aurabindo.in ^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-16 1:45 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-04-09 19:52 [PATCH] drm: dpcd: Print more useful information during error Aurabindo Pillai 2020-04-14 11:03 ` Jani Nikula 2020-04-16 1:44 ` Aurabindo Pillai
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox