From: Eric Anholt <eric@anholt.net>
To: Kees Cook <keescook@chromium.org>
Cc: Stefan Wahren <stefan.wahren@i2se.com>,
Arnd Bergmann <arnd@arndb.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fixup! firmware: raspberrypi: Remove VLA usage
Date: Thu, 05 Jul 2018 12:27:17 -0700 [thread overview]
Message-ID: <87o9fltre2.fsf@anholt.net> (raw)
In-Reply-To: <CAGXu5jLqkdSYd4MWPm9v49U+6FvgfMLtG1Vz3SUBR999vHshHQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1297 bytes --]
Kees Cook <keescook@chromium.org> writes:
> On Mon, Jul 2, 2018 at 12:45 PM, Eric Anholt <eric@anholt.net> wrote:
>> Kees - with this fix to your patch, the kernel boots again (otherwise,
>> the FW would try to parse the uninitialized bits of stack and throw
>> errors). If you're good with me squashing this in, I'll do so and
>> send it to -next.
>>
>> Signed-off-by: Eric Anholt <eric@anholt.net>
>> ---
>> drivers/firmware/raspberrypi.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/firmware/raspberrypi.c b/drivers/firmware/raspberrypi.c
>> index b80f15214b73..a200a2174611 100644
>> --- a/drivers/firmware/raspberrypi.c
>> +++ b/drivers/firmware/raspberrypi.c
>> @@ -162,7 +162,7 @@ int rpi_firmware_property(struct rpi_firmware *fw,
>> memcpy(data + sizeof(struct rpi_firmware_property_tag_header),
>> tag_data, buf_size);
>>
>> - ret = rpi_firmware_property_list(fw, &data, sizeof(data));
>> + ret = rpi_firmware_property_list(fw, &data, buf_size + sizeof(*header));
>> memcpy(tag_data,
>> data + sizeof(struct rpi_firmware_property_tag_header),
>> buf_size);
>
> Eek! Yes, thank you. Yeah, please feel free to squash. Thanks for testing!
Squashed and sent the PR. Thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2018-07-05 19:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Message-ID: <20180629184449.GA37304@beast>
2018-07-02 19:45 ` [PATCH] fixup! firmware: raspberrypi: Remove VLA usage Eric Anholt
2018-07-02 21:05 ` Kees Cook
2018-07-05 19:27 ` Eric Anholt [this message]
2018-06-29 18:44 [PATCH] " Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9fltre2.fsf@anholt.net \
--to=eric@anholt.net \
--cc=arnd@arndb.de \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox