From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751913AbdBAJCt (ORCPT ); Wed, 1 Feb 2017 04:02:49 -0500 Received: from mga03.intel.com ([134.134.136.65]:3705 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751713AbdBAJCr (ORCPT ); Wed, 1 Feb 2017 04:02:47 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,319,1477983600"; d="asc'?scan'208";a="220014981" From: Felipe Balbi To: Greg KH , Stefan Agner Cc: andrzej.p@samsung.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] fs: configfs: use hexadecimal values and new line In-Reply-To: <20170201080706.GB17968@kroah.com> References: <20170201021917.27398-1-stefan@agner.ch> <20170201021917.27398-2-stefan@agner.ch> <20170201080706.GB17968@kroah.com> Date: Wed, 01 Feb 2017 11:02:30 +0200 Message-ID: <87o9ym2sih.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Greg KH writes: > On Tue, Jan 31, 2017 at 06:19:17PM -0800, Stefan Agner wrote: >> Other unsigned properties return hexadecimal values, follow this >> convention when printing b_vendor_code too. Also add newlines to >> the OS Descriptor support related properties, like other sysfs >> files use. > > configfs is not sysfs, so watch out, you might not need/want those new > lines as tools read the values and are not expecting them. > > Have you verified that nothing will break with this? How have you > tested it? I would rather not change things like that, specially since Android guys are alreadying using configfs. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAliRpCYACgkQzL64meEa mQYWLRAAzr6lEaPyQjX6S5zPNSQzLFGQYtVwGX7IanNIPnnKnJNXbd/8QrEqCAh6 /7Osk/OtsJWwkgfusSrbsaVNDGVs90p6HJy8DpZ0ifF3OFZPI+wB+6dzC7mh8maf /fVOObzd46FOBvaNU/5UXqJmfICyD7ekHsuNwmRft72ZBKQ7CbioohjMR4ArDsXK jPba30fyPdPh1cQXXS9Uf9Li5n/IVvjPXAGN+En/EevAPvxR2mciMMZ8EPl/Nza1 LTh84ghW3vh8d2pduaEdr8OvW2ICVTGLv9qZ4/B8+7PiRPqYdxtcWDootb7zqYGk xQa+s8ZClgw8V9uXgWMVocNeOWr0c0r0TEq8NPmxBEFdosGsQHeyqmbBm7xfSAhU JX8ex3BAlgeoU1W2XhCaJufT/X5YeM6sVuyNYxWMWPuQ62qc9e5suqZKgowbGI5b o82aD7ZPdsJYw5z2Xe0z4/OaSZ3Mm3C/kXoOvNa2LH1lKsbL1x0hC7ww52BaThGS FuPpO2aZlauE4kK4Kf1xo3fVrvkrI27CMGRDDrRkYOnjkT/lsDf4BIHLa1UVvGt6 XnJvsDplZXgR7P3JZz/7Rrb9XE2W+ZVNCHgaxlmVPjFzQtsdOqJoeNcwzeIB747y f5kmNwINJQvx8jw5+R7noihBl5e5xJG9oTlCpqFbyUdpCTD5d7M= =X9Uy -----END PGP SIGNATURE----- --=-=-=--