From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754769AbcJOVRU (ORCPT ); Sat, 15 Oct 2016 17:17:20 -0400 Received: from smtp03.smtpout.orange.fr ([80.12.242.125]:16497 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751537AbcJOVRN (ORCPT ); Sat, 15 Oct 2016 17:17:13 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Sat, 15 Oct 2016 23:17:11 +0200 X-ME-IP: 109.220.223.51 From: Robert Jarzmik To: Russell King - ARM Linux Cc: Daniel Mack , Haojian Zhuang , Rob Herring , Mark Rutland , Rafael Wysocki , Viresh Kumar , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v2 0/4] PXA cpufreq conversion to clock API References: <1476561450-28407-1-git-send-email-robert.jarzmik@free.fr> <20161015203421.GG1041@n2100.armlinux.org.uk> X-URL: http://belgarath.falguerolles.org/ Date: Sat, 15 Oct 2016 23:17:08 +0200 In-Reply-To: <20161015203421.GG1041@n2100.armlinux.org.uk> (Russell King's message of "Sat, 15 Oct 2016 21:34:21 +0100") Message-ID: <87oa2l5n3f.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Russell King - ARM Linux writes: > On Sat, Oct 15, 2016 at 09:57:26PM +0200, Robert Jarzmik wrote: >> Hi, >> >> This serie is a preparation to shift the cpufreq of pxa2xx platforms to clocks >> API. >> >> The first 3 patches are review and merge material : >> - patch 1/4 for Viresh and Rafael >> - patches 2/4 and 3/4 for me >> >> The 4th on is for review but not merge, as the clock changes must be fully >> reviewed and go in first as a prequisite > > Have you tested whether this patch set results in functional cpufreq > support - looking at drivers/clk/pxa, the CPU clock is read-only - > it can't be used to change the clock rate. So, I very much doubt this > has been functionally tested. Oh yes I did, on lubbock and mainstone ... but this requires another patchset under review, here : https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1247123.html > Don't forget that changing the CPU clock rate needs other changes > (like the memory clock rate) so all that code you're removing in > patch 4 (which does the actual clock change) needs to go somewhere. Sure, here : https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1247130.html I would have been wiser to quote these URLs instead of speaking of "clock changes must be fully review and go in first as a prequisite". Cheers. -- Robert