From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753816AbcHRHP6 (ORCPT ); Thu, 18 Aug 2016 03:15:58 -0400 Received: from mga03.intel.com ([134.134.136.65]:1340 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753538AbcHRHP5 (ORCPT ); Thu, 18 Aug 2016 03:15:57 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,538,1464678000"; d="asc'?scan'208";a="1037652563" From: Felipe Balbi To: "Felipe F. Tonello" , linux-usb@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Michal Nazarewicz Subject: Re: [PATCH v4 08/10] usb: gadget: remove useless parameter in alloc_ep_req() In-Reply-To: <20160808203013.19283-9-eu@felipetonello.com> References: <20160808203013.19283-1-eu@felipetonello.com> <20160808203013.19283-9-eu@felipetonello.com> User-Agent: Notmuch/0.22.1+63~g994277e (https://notmuchmail.org) Emacs/25.1.1 (x86_64-pc-linux-gnu) Date: Thu, 18 Aug 2016 10:12:37 +0300 Message-ID: <87oa4q5z4q.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, "Felipe F. Tonello" writes: > The default_length parameter of alloc_ep_req was not really necessary > and gadget drivers would almost always create an inline function to pass > the same value to len and default_len. > > So this patch also removes duplicate code from few drivers. > > Signed-off-by: Felipe F. Tonello > --- > drivers/usb/gadget/function/f_hid.c | 10 ++-------- > drivers/usb/gadget/function/f_loopback.c | 9 +-------- > drivers/usb/gadget/function/f_midi.c | 10 ++-------- > drivers/usb/gadget/function/f_sourcesink.c | 11 ++--------- > drivers/usb/gadget/u_f.c | 7 +++---- > drivers/usb/gadget/u_f.h | 3 +-- > 6 files changed, 11 insertions(+), 39 deletions(-) > > diff --git a/drivers/usb/gadget/function/f_hid.c b/drivers/usb/gadget/fun= ction/f_hid.c > index 51980c50546d..e82a7468252e 100644 > --- a/drivers/usb/gadget/function/f_hid.c > +++ b/drivers/usb/gadget/function/f_hid.c > @@ -362,12 +362,6 @@ static int f_hidg_open(struct inode *inode, struct f= ile *fd) > /*----------------------------------------------------------------------= ---*/ > /* usb_function = */ >=20=20 > -static inline struct usb_request *hidg_alloc_ep_req(struct usb_ep *ep, > - unsigned length) > -{ > - return alloc_ep_req(ep, length, length); > -} actually, I prefer to keep these little helpers. I was recently playing with adding SG list support to g_zero (I should have patches soon) and it was actually very nice to have the sourcesink helper as I could just ditch alloc_ep_req(). The change to the driver was local to ss_alloc_ep_req() and nothing else changed :-) =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJXtV/lAAoJEIaOsuA1yqREtbIQALXGJWHvogCgc3LDr6XgynB4 r0HQZR0YqyDawKBoj7eg4N+xApgdlouqKygFdqzf200/tDoQGcZTcERdq0Kl1KjR YacdKlT6vDUFd35LFgyvJF9c6r2nWaPx4fdmAIAEtzdKqTxPkggSjGP9UjulCndd jf89Pvw8xugdOrSRygYLfHfttAjyIshF4OaTr34nhhDtyYynI80ydi581Tg4o6LW BAoz0PxWcvy2tFw5kp+R5oaS8Zc/I+qnbgC7R2OmDtxDUPsQrNTHWm7bwJ/U3w7i gg1YLxBBFEladA8wrEAKStDKt4RYJDSBZr1RG45z/f7UHwH/hfbFnoo6wbckvJwH s5qd0y749I+nKNat+SWlgywFPvpz1tZwwk4t+v0+Wp8C3mUcLrRxcJVmxG7+hL02 tkKBoupXMolw1KJMstafPPAVMRBn9MRNO6dJR73Js4E+faMwQVQUZVsji0D9iHxu tkTrZJDlZ5Bl9I4/2Dq+7uEnRAB3GpylIYXYK0bP6CtG0b0HD8aYC7gttcUxPn9Y yAWqRzCjy1Omu1wQGlkrFoNlAcbyGf3A72XSDBTQxDuGdMrNE8IceD9a3BXIse0k SZ3ZBoaVGx9Ee81IADwxQZByKGJibWyWJ1kmo1Rsyq5G7FxTDPO2K69fC1CPMZU0 y/9zOyqwckSzZDKJ8fdy =lwSw -----END PGP SIGNATURE----- --=-=-=--