public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Tejun Heo <htejun@gmail.com>
Cc: Louis Langholtz <lou_langholtz@me.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: kernel/params.c: 'err' variable "set but not used" and perhaps should be?
Date: Fri, 05 Jun 2015 10:09:29 +0930	[thread overview]
Message-ID: <87oakvt2da.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20150604203034.GS20091@mtj.duckdns.org>

Tejun Heo <htejun@gmail.com> writes:
> On Fri, Jun 05, 2015 at 05:16:53AM +0930, Rusty Russell wrote:
>> Tejun Heo <htejun@gmail.com> writes:
>> > On Thu, Jun 04, 2015 at 11:03:16AM +0930, Rusty Russell wrote:
>> >> Please describe the circumstances under which this function can fail.
>> >
>> > Allocation failure obviously
>> 
>> Won't happen here, this is a boot-time function.  version_sysfs_builtin.
>> The __init is the clue.
>
> Yes, that's this one callsite.  There are whole others which can fail.
> Just add WARN_ON here.  What are you arguing?

What will a second warning which is never triggered achieve?  A bit of
code bloat and confusion, when I really do want to ignore the value.

I've asked (again) for gcc to allow cast to void:

        https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66425

Thanks,
Rusty.

  reply	other threads:[~2015-06-05  2:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <FFF42EF7-42DB-4D5C-9C86-D8773E20D255@me.com>
     [not found] ` <87vbf628uy.fsf@rustcorp.com.au>
2015-06-03 19:41   ` kernel/params.c: 'err' variable "set but not used" and perhaps should be? Louis Langholtz
2015-06-03 20:22     ` Tejun Heo
2015-06-04  1:33       ` Rusty Russell
2015-06-04  2:19         ` Tejun Heo
2015-06-04 19:46           ` Rusty Russell
2015-06-04 20:30             ` Tejun Heo
2015-06-05  0:39               ` Rusty Russell [this message]
2015-06-05 14:24                 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oakvt2da.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=akpm@linux-foundation.org \
    --cc=htejun@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lou_langholtz@me.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox