From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751537AbbEGNsU (ORCPT ); Thu, 7 May 2015 09:48:20 -0400 Received: from mga09.intel.com ([134.134.136.24]:35445 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751352AbbEGNsR (ORCPT ); Thu, 7 May 2015 09:48:17 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,384,1427785200"; d="scan'208";a="722226128" From: Jani Nikula To: Martin Kepplinger , daniel.vetter@intel.com, airlied@linux.ie Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, "linux-kernel\@vger.kernel.org" Subject: Re: [BUG] i915: suspend by closing Laptop lid broken In-Reply-To: <554B6A1B.9050201@posteo.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <55474FD2.7070600@posteo.de> <87a8xk8u20.fsf@intel.com> <554B6A1B.9050201@posteo.de> User-Agent: Notmuch/0.19+112~g77230b0 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Thu, 07 May 2015 16:50:06 +0300 Message-ID: <87oalw5wfl.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 07 May 2015, Martin Kepplinger wrote: > Am 2015-05-04 um 13:24 schrieb Jani Nikula: >> On Mon, 04 May 2015, Martin Kepplinger wrote: >>> So. -rc1 broke suspending by closing my laptop lid and it's not fixed in >>> -rc2. It works exactly *one* first time and every subsequent lid-closing >>> is ignored. >>> >>> Biscted and tested first bad commit: >>> 14aa02449064541217836b9f3d3295e241d5ae9c >>> >>> This pulls in i915 changes as well as ACPI changes. I don't know the >>> driver but I'm sure you can find the mistake. I'm happy to test changes. >>> >>> There are no log differences. >> >> Any chance you could bisect into the merge? It would be helpful. >> >> BR, >> Jani. >> >> > > My attempt to go into the merge was too much effort as the checkouts in > between break random other stuff. This should obviously *not* be the case. :( > We should be between 09d51602cf84a1264946711dd4ea0dddbac599a1 (good) and > c0f404284192f2d4a0159a714372a8c8610c1f6d. Could you have a look and > maybe you have guesses for me, what I should test? It's not sooo much > anymore, maybe you even have a guess about the bug? $ git log --oneline 09d51602cf..c0f4042841 | grep drm/i915 | wc -l 286 Oof, I eyeballed the list, but didn't spot any obvious candidates. If a commit is inconclusive or borken in other ways, you could try git bisect skip to try another commit... BR, Jani. -- Jani Nikula, Intel Open Source Technology Center