From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753910AbaHUHBH (ORCPT ); Thu, 21 Aug 2014 03:01:07 -0400 Received: from mga02.intel.com ([134.134.136.20]:21639 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753672AbaHUHBF (ORCPT ); Thu, 21 Aug 2014 03:01:05 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,907,1400050800"; d="scan'208";a="591188663" From: Jani Nikula To: Rusty Russell , Daniel Vetter Cc: Linux Kernel Mailing List , intel-gfx , Jean Delvare , Andrew Morton , Li Zhong , Jon Mason Subject: Re: [PATCH 0/4] module: add support for unsafe, tainting parameters In-Reply-To: <87ppfvi1hx.fsf@rustcorp.com.au> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <87wqac87dq.fsf@rustcorp.com.au> <87ppfvi1hx.fsf@rustcorp.com.au> User-Agent: Notmuch/0.18.1+66~g7487985 (http://notmuchmail.org) Emacs/23.4.1 (x86_64-pc-linux-gnu) Date: Thu, 21 Aug 2014 10:00:48 +0300 Message-ID: <87oavemin3.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 20 Aug 2014, Rusty Russell wrote: > I've applied this cleanup on top, however. > > Cheers, > Rusty. > > Subject: param: check for tainting before calling set op. > > This means every set op doesn't need to call it, and it can move into > params.c. Much better, thanks. I was looking for a way to do something like this, but obviously didn't look hard enough. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center