From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754623AbaGNLeE (ORCPT ); Mon, 14 Jul 2014 07:34:04 -0400 Received: from ozlabs.org ([103.22.144.67]:32799 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754110AbaGNLdq (ORCPT ); Mon, 14 Jul 2014 07:33:46 -0400 From: Rusty Russell To: Russell King Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: avoid ARM binutils leaking ELF local symbols In-Reply-To: References: User-Agent: Notmuch/0.17 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Mon, 14 Jul 2014 19:44:40 +0930 Message-ID: <87oaws457z.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Russell King writes: > Symbols starting with .L are ELF local symbols and should not appear > in ELF symbol tables. However, unfortunately ARM binutils leaks the > .LANCHOR symbols into the symbol table, which leads kallsyms to report > these symbols rather than the real name. It is not very useful when > %pf reports symbols against these leaked .LANCHOR symbols. > > Arrange for kallsyms to ignore these symbols using the same mechanism > that is used for the ARM mapping symbols. Yech... Applied. Thanks, Rusty. > Signed-off-by: Russell King > --- > kernel/module.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/kernel/module.c b/kernel/module.c > index 81e727cf6df9..cecd78d06025 100644 > --- a/kernel/module.c > +++ b/kernel/module.c > @@ -3385,6 +3385,8 @@ static inline int within(unsigned long addr, void *start, unsigned long size) > */ > static inline int is_arm_mapping_symbol(const char *str) > { > + if (str[0] == '.' && str[1] == 'L') > + return true; > return str[0] == '$' && strchr("atd", str[1]) > && (str[2] == '\0' || str[2] == '.'); > } > -- > 1.8.3.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/