From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755405Ab3JHNhf (ORCPT ); Tue, 8 Oct 2013 09:37:35 -0400 Received: from mail1.bemta12.messagelabs.com ([216.82.251.11]:5303 "EHLO mail1.bemta12.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754465Ab3JHNhc convert rfc822-to-8bit (ORCPT ); Tue, 8 Oct 2013 09:37:32 -0400 X-Greylist: delayed 398 seconds by postgrey-1.27 at vger.kernel.org; Tue, 08 Oct 2013 09:37:32 EDT X-Env-Sender: peter.korsgaard@barco.com X-Msg-Ref: server-12.tower-29.messagelabs.com!1381239050!23303960!1 X-Originating-IP: [91.183.172.68] X-StarScan-Received: X-StarScan-Version: 6.9.12; banners=-,-,- X-VirusChecked: Checked From: Peter Korsgaard To: Ionut Nicu CC: Wolfram Sang , Alexander Sverdlin , , Subject: Re: [PATCH] i2c-mux-gpio: use deferred probing with the device tree References: <52540692.9080208@nsn.com> X-message-flag: thor uptime: 538 days, 16:35, 7 users Date: Tue, 8 Oct 2013 15:30:49 +0200 In-Reply-To: <52540692.9080208@nsn.com> (Ionut Nicu's message of "Tue, 8 Oct 2013 15:20:18 +0200") Message-ID: <87ob6znb3q.fsf@thor.barco.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "IN" == Ionut Nicu writes: IN> If the i2c-parent bus driver is not loaded, returning IN> -EINVAL will force people to unload and then reload the IN> module again to get it working. IN> Also of_get_named_gpio could return -E_PROBE_DEFER or IN> another error code. This error should be passed further IN> instead of being ignored. Two different fixes, so should be 2 separate patches. Other that that, it looks good. Acked-by: Peter Korsgaard -- Sorry about disclaimer - It's out of my control. Bye, Peter Korsgaard This message is subject to the following terms and conditions: MAIL DISCLAIMER