From: Rusty Russell <rusty@rustcorp.com.au>
To: Rob Landley <rob@landley.net>,
Pranavkumar Sawargaonkar <pranavkumar@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org,
linaro-kernel@lists.linaro.org, patches@linaro.org,
anup.patel@linaro.org, amit.shah@redhat.com,
Pranavkumar Sawargaonkar <pranavkumar@linaro.org>
Subject: Re: [PATCH V2 2/3] Documentation: virtio: Add emergency write (emerg_wr) config register in virtio console.
Date: Mon, 13 May 2013 10:46:07 +0930 [thread overview]
Message-ID: <87obcf3ciw.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1367902933.18069.212@driftwood>
Rob Landley <rob@landley.net> writes:
> On 05/06/2013 07:19:50 AM, Pranavkumar Sawargaonkar wrote:
>> Signed-off-by: Pranavkumar Sawargaonkar <pranavkumar@linaro.org>
>> Signed-off-by: Anup Patel <anup.patel@linaro.org>
>> ---
>> Documentation/virtual/virtio-spec.txt | 8 +++++++-
>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/virtual/virtio-spec.txt
>> b/Documentation/virtual/virtio-spec.txt
>> index 0d6ec85..3ca38f8 100644
>> --- a/Documentation/virtual/virtio-spec.txt
>> +++ b/Documentation/virtual/virtio-spec.txt
>> @@ -1927,11 +1927,16 @@ Ports 2 onwards only if
>> VIRTIO_CONSOLE_F_MULTIPORT is set
>> ports; configuration fields nr_ports and max_nr_ports are
>> valid and control virtqueues will be used.
>>
>> + VIRTIO_CONSOLE_F_EMERG_WRITE(2) Device has support for emergency
>> + write. Configuration filed emerg_wr is valid.
>
> Emergency?
>
> Really?
>
> Out of morbid curiosity, what would constitute an _emergency_ in a
> virtual machine logging context?
Usually, your console device is broken. Or you can't set it up because
you can't allocate memory. Or you oops before it is configured.
Terminology is a tricky thing, but the nuance here is that you don't
want to use this as your main console. It may not do anything. It may
drop characters. It's definitely slow.
Cheers,
Rusty.
next prev parent reply other threads:[~2013-05-13 2:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 12:19 [PATCH V2 0/3] Emergency write support for virtio console devices Pranavkumar Sawargaonkar
2013-05-06 12:19 ` [PATCH V2 1/3] virtio: console: Add emergency writeonly register to config space Pranavkumar Sawargaonkar
2013-05-16 12:37 ` Amit Shah
2013-05-16 23:52 ` Rusty Russell
2013-05-17 6:00 ` Pranavkumar Sawargaonkar
2013-05-06 12:19 ` [PATCH V2 2/3] Documentation: virtio: Add emergency write (emerg_wr) config register in virtio console Pranavkumar Sawargaonkar
2013-05-07 5:02 ` Rob Landley
2013-05-13 1:16 ` Rusty Russell [this message]
2013-05-13 2:52 ` Rusty Russell
2013-05-13 6:56 ` Pranavkumar Sawargaonkar
2013-05-13 17:36 ` Christopher Covington
2013-05-15 4:29 ` Rusty Russell
2013-05-15 5:30 ` Amit Shah
2013-05-06 12:19 ` [PATCH V2 3/3] arm64: earlyprintk support for virtio-mmio console Pranavkumar Sawargaonkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87obcf3ciw.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=amit.shah@redhat.com \
--cc=anup.patel@linaro.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
--cc=pranavkumar@linaro.org \
--cc=rob@landley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox