From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Gu Zheng <guz.fnst@cn.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fs/fat: Use fat_msg() to replace printk() in __fat_fs_error()
Date: Mon, 13 May 2013 18:28:27 +0900 [thread overview]
Message-ID: <87obcfqldw.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <5190AAB9.5080904@cn.fujitsu.com> (Gu Zheng's message of "Mon, 13 May 2013 16:56:25 +0800")
Gu Zheng <guz.fnst@cn.fujitsu.com> writes:
>>From 87141ec058aad35ac55bc7c3fc2eb378566a5a6a Mon Sep 17 00:00:00 2001
> From: Gu Zheng <guz.fnst@cn.fujitsu.com>
> Date: Mon, 13 May 2013 17:48:19 +0900
> Subject: [PATCH] fs/fat: Use fat_msg() to replace printk() in __fat_fs_error()
> - printk(KERN_ERR "FAT-fs (%s): error, %pV\n", sb->s_id, &vaf);
> + fat_msg(sb, KERN_ERR, "error, %pV", &vaf);
> va_end(args);
I'm assuming nested "%pV" is works fine. If so,
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
> @@ -38,8 +38,7 @@ void __fat_fs_error(struct super_block *sb, int report, const char *fmt, ...)
> panic("FAT-fs (%s): fs panic from previous error\n", sb->s_id);
> else if (opts->errors == FAT_ERRORS_RO && !(sb->s_flags & MS_RDONLY)) {
> sb->s_flags |= MS_RDONLY;
> - printk(KERN_ERR "FAT-fs (%s): Filesystem has been "
> - "set read-only\n", sb->s_id);
> + fat_msg(sb, KERN_ERR, "Filesystem has been set read-only");
> }
> }
> EXPORT_SYMBOL_GPL(__fat_fs_error);
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2013-05-13 9:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 8:56 [PATCH] fs/fat: Use fat_msg() to replace printk() in __fat_fs_error() Gu Zheng
2013-05-13 9:28 ` OGAWA Hirofumi [this message]
2013-05-14 3:16 ` Gu Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87obcfqldw.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=akpm@linux-foundation.org \
--cc=guz.fnst@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox