From: Rusty Russell <rusty@rustcorp.com.au>
To: Frank Swiderski <fes@google.com>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: Rik van Riel <riel@redhat.com>,
Andrea Arcangeli <aarcange@redhat.com>,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
mikew@google.com, Ying Han <yinghan@google.com>,
Rafael Aquini <aquini@redhat.com>
Subject: Re: [PATCH] Add a page cache-backed balloon device driver.
Date: Mon, 02 Jul 2012 09:59:16 +0930 [thread overview]
Message-ID: <87obnzxaxv.fsf@rustcorp.com.au> (raw)
In-Reply-To: <CAK+C7kUN-kYVK9AnEhcof98p+eZN1dkt9qVyYppETOeS2n3CMQ@mail.gmail.com>
On Tue, 26 Jun 2012 16:21:58 -0700, Frank Swiderski <fes@google.com> wrote:
> On Tue, Jun 26, 2012 at 2:47 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> > Let's assume it's a feature bit: how would you
> > formulate what the feature does *from host point of view*?
>
> In this implementation, the host doesn't keep track of pages in the
> balloon, as there is no explicit deflate path. The host device for
> this implementation should merely, for example, MADV_DONTNEED on the
> pages sent in an inflate. Thus, the inflate becomes a notification
> that the guest doesn't need those pages mapped in, but that they
> should be available if the guest touches them. In that sense, it's
> not a rigid shrink of guest memory. I'm not sure what I'd call the
> feature bit though.
>
> Was that the question you were asking, or did I misread?
Hmm, the spec is unfortunately vague: !VIRTIO_BALLOON_F_MUST_TELL_HOST
implies you should tell the host (eventually). I don't know if any
implementations actually care though.
We could add a VIRTIO_BALLOON_F_NEVER_TELL_DEFLATE which would mean the
deflate vq need not be used at all.
Is it altogether impossible to know when a page is reused in your
implementation? If we could do that, we could replace our balloon with
this one.
(My deep ignorance of vm issues is hurting us here, sorry.)
Cheers,
Rusty.
next prev parent reply other threads:[~2012-07-02 1:52 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 20:32 [PATCH] Add a page cache-backed balloon device driver Frank Swiderski
2012-06-26 20:40 ` Rik van Riel
2012-06-26 21:31 ` Frank Swiderski
2012-06-26 21:45 ` Rik van Riel
2012-06-26 23:45 ` Frank Swiderski
2012-06-27 9:04 ` Michael S. Tsirkin
2012-06-26 21:47 ` Michael S. Tsirkin
2012-06-26 23:21 ` Frank Swiderski
2012-06-27 9:02 ` Michael S. Tsirkin
2012-07-02 0:29 ` Rusty Russell [this message]
2012-09-03 6:35 ` Paolo Bonzini
2012-09-06 1:35 ` Rusty Russell
2012-06-26 21:41 ` Michael S. Tsirkin
2012-06-27 2:56 ` Rusty Russell
2012-06-27 15:48 ` Frank Swiderski
2012-06-27 16:06 ` Michael S. Tsirkin
2012-06-27 16:08 ` Frank Swiderski
2012-06-27 9:40 ` Amit Shah
2012-08-30 8:57 ` Michael S. Tsirkin
2012-09-03 15:09 ` Avi Kivity
2012-09-10 9:05 ` Michael S. Tsirkin
2012-09-10 17:37 ` Mike Waychison
2012-09-10 18:04 ` Rik van Riel
2012-09-10 18:29 ` Mike Waychison
2012-09-10 19:59 ` Michael S. Tsirkin
2012-09-10 20:49 ` Mike Waychison
2012-09-10 21:10 ` Michael S. Tsirkin
2012-10-30 15:29 ` Michael S. Tsirkin
2012-10-30 16:25 ` Mike Waychison
2012-09-12 5:25 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87obnzxaxv.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=aarcange@redhat.com \
--cc=aquini@redhat.com \
--cc=fes@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikew@google.com \
--cc=mst@redhat.com \
--cc=riel@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox