From: Rusty Russell <rusty@rustcorp.com.au>
To: Matthew Shaw <shaw500@gmail.com>
Cc: linux-kernel@vger.kernel.org, Matthew Shaw <shaw500@gmail.com>
Subject: Re: [PATCH] init: main: Corrected some coding style issues.
Date: Sun, 10 Jun 2012 16:03:31 +0930 [thread overview]
Message-ID: <87oborhe10.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1339261575-2318-1-git-send-email-shaw500@gmail.com>
On Sat, 9 Jun 2012 18:06:15 +0100, Matthew Shaw <shaw500@gmail.com> wrote:
> diff --git a/init/main.c b/init/main.c
> index 1ca6b32..66125f0 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -6,7 +6,7 @@
> * GK 2/5/95 - Changed to support mounting root fs via NFS
> * Added initrd & change_root: Werner Almesberger & Hans Lermen, Feb '96
> * Moan early if gcc is old, avoiding bogus kernels - Paul Gortmaker, May '96
> - * Simplified starting of init: Michael A. Griffith <grif@acm.org>
> + * Simplified starting of init: Michael A. Griffith <grif@acm.org>
> */
>
> #include <linux/types.h>
> @@ -148,8 +148,8 @@ static int __init set_reset_devices(char *str)
>
> __setup("reset_devices", set_reset_devices);
>
> -static const char * argv_init[MAX_INIT_ARGS+2] = { "init", NULL, };
> -const char * envp_init[MAX_INIT_ENVS+2] = { "HOME=/", "TERM=linux", NULL, };
> +static const char *argv_init[MAX_INIT_ARGS+2] = { "init", NULL, };
> +const char *envp_init[MAX_INIT_ENVS+2] = { "HOME=/", "TERM=linux", NULL, };
> static const char *panic_later, *panic_param;
>
> extern const struct obs_kernel_param __setup_start[], __setup_end[];
> @@ -464,7 +464,7 @@ static void __init mm_init(void)
>
> asmlinkage void __init start_kernel(void)
> {
> - char * command_line;
> + char *command_line;
> extern const struct kernel_param __start___param[], __stop___param[];
>
> /*
> @@ -838,7 +838,7 @@ static noinline int init_post(void)
> "See Linux Documentation/init.txt for guidance.");
> }
>
> -static int __init kernel_init(void * unused)
> +static int __init kernel_init(void *unused)
> {
> /*
> * Wait until kthreadd is all set-up.
Please send to the trivial patch monkey.
Thanks,
Rusty.
next prev parent reply other threads:[~2012-06-10 6:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-09 17:06 [PATCH] init: main: Corrected some coding style issues Matthew Shaw
2012-06-10 6:33 ` Rusty Russell [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-06-02 19:27 Matthew Shaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oborhe10.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=shaw500@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox