From: Nix <nix@esperi.org.uk>
To: Chris Boot <bootc@bootc.net>
Cc: e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, carolyn.wyborny@intel.com
Subject: Re: [PATCH 1/2] e1000e: Disable ASPM L1 on 82574
Date: Tue, 24 Apr 2012 12:08:09 +0100 [thread overview]
Message-ID: <87obqh75gm.fsf@spindle.srvr.nix> (raw)
In-Reply-To: <1335216578-21542-2-git-send-email-bootc@bootc.net> (Chris Boot's message of "Mon, 23 Apr 2012 22:29:37 +0100")
On 23 Apr 2012, Chris Boot uttered the following:
> ASPM on the 82574 causes trouble. Currently the driver disables L0s for
> this NIC but only disables L1 if the MTU is >1500. This patch simply
> causes L1 to be disabled regardless of the MTU setting.
FWIW, that existing code doesn't actually work in any case. I've been
running with an MTU of 7200 on one such NIC for some time, and L0s and
L1 are definitely enabled, even though the driver says it's turning them
off.
I'll try your patch shortly, probably tomorrow. (Now I only have to
worry about the *other* bug that's been bruited about on this list --
the one where the card locks up if its peer shuts down. It's worrying
because one of my 82574Ls has a peer that's regularly suspended... I
guess I'll try and see if I can reproduce that lockup!)
--
NULL && (void)
next prev parent reply other threads:[~2012-04-24 11:08 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-27 22:01 e1000e interface hang on 82574L Chris Boot
2011-12-27 22:33 ` Dave Taht
2011-12-31 9:31 ` Chris Boot
2012-01-03 0:02 ` Wyborny, Carolyn
2012-01-04 17:12 ` Chris Boot
2012-01-15 11:10 ` Chris Boot
2012-01-16 15:56 ` Wyborny, Carolyn
2012-01-16 16:04 ` Chris Boot
2012-03-17 15:59 ` Chris Boot
2012-03-17 17:54 ` Chris Boot
2012-03-17 23:50 ` [E1000-devel] " Nix
2012-03-19 14:59 ` Wyborny, Carolyn
2012-03-19 16:19 ` [E1000-devel] " Nix
2012-03-19 16:29 ` Wyborny, Carolyn
2012-03-19 17:31 ` Nix
2012-04-06 10:17 ` Chris Boot
2012-04-06 12:12 ` Bjorn Helgaas
2012-04-06 13:41 ` Henrique de Moraes Holschuh
2012-04-06 13:48 ` Chris Boot
2012-04-06 16:05 ` Nix
2012-04-06 16:04 ` Nix
2012-04-23 21:29 ` [PATCH RFC 0/2] e1000e: 82574 also needs ASPM L1 completely disabled Chris Boot
2012-04-23 21:29 ` [PATCH 1/2] e1000e: Disable ASPM L1 on 82574 Chris Boot
2012-04-23 23:18 ` [E1000-devel] " Jeff Kirsher
2012-04-24 11:08 ` Nix [this message]
2012-06-01 21:17 ` Chris Boot
2012-06-07 1:41 ` Greg KH
2012-04-23 21:29 ` [PATCH 2/2] e1000e: Remove special case for 82573/82574 ASPM L1 disablement Chris Boot
2012-04-23 23:18 ` [E1000-devel] " Jeff Kirsher
2012-04-23 23:11 ` [PATCH RFC 0/2] e1000e: 82574 also needs ASPM L1 completely disabled Jesse Brandeburg
2012-04-29 16:45 ` Nix
2012-04-29 18:03 ` Chris Boot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87obqh75gm.fsf@spindle.srvr.nix \
--to=nix@esperi.org.uk \
--cc=bootc@bootc.net \
--cc=carolyn.wyborny@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox