* [PATCH] lockdep: Don't disable lockdep for out of tree modules
@ 2011-11-16 7:50 Aneesh Kumar K.V
2011-11-16 8:46 ` Peter Zijlstra
0 siblings, 1 reply; 3+ messages in thread
From: Aneesh Kumar K.V @ 2011-11-16 7:50 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar; +Cc: linux-kernel, Aneesh Kumar K.V
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
I guess it would be nice to get lockdep enabled for out of tree GPL modules
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
---
kernel/panic.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/kernel/panic.c b/kernel/panic.c
index b2659360..3bd7088 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -240,7 +240,8 @@ void add_taint(unsigned flag)
* Also we want to keep up lockdep for staging development and
* post-warning case.
*/
- if (flag != TAINT_CRAP && flag != TAINT_WARN && __debug_locks_off())
+ if (flag != TAINT_CRAP && flag != TAINT_WARN &&
+ flag != TAINT_OOT_MODULE && __debug_locks_off())
printk(KERN_WARNING "Disabling lock debugging due to kernel taint\n");
set_bit(flag, &tainted_mask);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] lockdep: Don't disable lockdep for out of tree modules
2011-11-16 7:50 [PATCH] lockdep: Don't disable lockdep for out of tree modules Aneesh Kumar K.V
@ 2011-11-16 8:46 ` Peter Zijlstra
2011-11-16 11:00 ` Aneesh Kumar K.V
0 siblings, 1 reply; 3+ messages in thread
From: Peter Zijlstra @ 2011-11-16 8:46 UTC (permalink / raw)
To: Aneesh Kumar K.V; +Cc: Ingo Molnar, linux-kernel
On Wed, 2011-11-16 at 13:20 +0530, Aneesh Kumar K.V wrote:
> From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
>
> I guess it would be nice to get lockdep enabled for out of tree GPL modules
How about you get them in staging instead?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] lockdep: Don't disable lockdep for out of tree modules
2011-11-16 8:46 ` Peter Zijlstra
@ 2011-11-16 11:00 ` Aneesh Kumar K.V
0 siblings, 0 replies; 3+ messages in thread
From: Aneesh Kumar K.V @ 2011-11-16 11:00 UTC (permalink / raw)
To: Peter Zijlstra; +Cc: Ingo Molnar, linux-kernel
On Wed, 16 Nov 2011 09:46:43 +0100, Peter Zijlstra <peterz@infradead.org> wrote:
> On Wed, 2011-11-16 at 13:20 +0530, Aneesh Kumar K.V wrote:
> > From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
> >
> > I guess it would be nice to get lockdep enabled for out of tree GPL modules
>
> How about you get them in staging instead?
>
I actually wanted to do a sample module to demo lockdep in one of the
presentation i am doing and that is when i hit the issue. I don't have
a kernel module that i would like to keep out of tree. I am not sure
there is any value in disabling lockdep if one load an out of tree GPL
kernel module.
-aneesh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-11-16 11:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-16 7:50 [PATCH] lockdep: Don't disable lockdep for out of tree modules Aneesh Kumar K.V
2011-11-16 8:46 ` Peter Zijlstra
2011-11-16 11:00 ` Aneesh Kumar K.V
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox