From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754930Ab1KNAtd (ORCPT ); Sun, 13 Nov 2011 19:49:33 -0500 Received: from ozlabs.org ([203.10.76.45]:56395 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751929Ab1KNAta (ORCPT ); Sun, 13 Nov 2011 19:49:30 -0500 From: Rusty Russell To: Kevin Cernekee Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Jan Beulich Subject: Re: [PATCH V2 2/2] module: Fix performance regression on modules with large symbol tables In-Reply-To: References: <73defb5e4bca04a6431392cc341112b1@localhost> User-Agent: Notmuch/0.6.1-1 (http://notmuchmail.org) Emacs/23.3.1 (i686-pc-linux-gnu) Date: Mon, 14 Nov 2011 11:05:14 +1030 Message-ID: <87obwfpmm5.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 12 Nov 2011 19:08:56 -0800, Kevin Cernekee wrote: > + /* > + * Copy the symbol name to mod->core_strtab. > + * "name" might point to the middle of a longer strtab > + * entry, so backtrack to the first "required" byte > + * of the string. > + */ Icky, but it works. Both applied, thanks! Rusty.