public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Jonathan Cameron <jic23@cam.ac.uk>, linux-kernel@vger.kernel.org
Cc: greg@kroah.com, adobriyan@gmail.com, Jonathan Cameron <jic23@cam.ac.uk>
Subject: Re: [PATCH 1/3] Add a usr_strtobool function matching semantics of existing in kernel equivalents
Date: Tue, 19 Apr 2011 11:06:23 +0930	[thread overview]
Message-ID: <87oc433tuw.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1300973025-32497-2-git-send-email-jic23@cam.ac.uk>

On Thu, 24 Mar 2011 13:23:43 +0000, Jonathan Cameron <jic23@cam.ac.uk> wrote:
> This is a renamed and relocated fixed version of previous kstrtobool RFC

Please just call it strtobool, usr_ implies it's a user pointer.

And there's no need to introduce a new var in debugfs, just do:

	if (strtobool(buf, &bv) == 0)
		*val = bv;

And yes, I'll take it for the param stuff.

Thanks,
Rusty.

  reply	other threads:[~2011-04-19  1:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-24 13:23 [RFC PATCH 0/3 V2] Introduce usr_strtobool (previously kstrtobool) Jonathan Cameron
2011-03-24 13:23 ` [PATCH 1/3] Add a usr_strtobool function matching semantics of existing in kernel equivalents Jonathan Cameron
2011-04-19  1:36   ` Rusty Russell [this message]
2011-04-19 11:31     ` Jonathan Cameron
2011-03-24 13:23 ` [PATCH 2/3] debugfs: move to new usr_strtobool Jonathan Cameron
2011-03-24 13:23 ` [PATCH 3/3] params.c: Use new usr_strtobool function to process boolean inputs Jonathan Cameron
2011-04-15 13:27 ` [RFC PATCH 0/3 V2] Introduce usr_strtobool (previously kstrtobool) Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oc433tuw.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=adobriyan@gmail.com \
    --cc=greg@kroah.com \
    --cc=jic23@cam.ac.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox