From: Robert Jarzmik <robert.jarzmik@free.fr>
To: "H Hartley Sweeten" <hartleys@visionengravers.com>
Cc: "kernel list" <linux-kernel@vger.kernel.org>,
<linux-usb@vger.kernel.org>,
"David Brownell" <dbrownell@users.sourceforge.net>
Subject: Re: [PATCH] pxa27x_udc.c: use resource_size()
Date: Wed, 16 Dec 2009 21:46:15 +0100 [thread overview]
Message-ID: <87oclytzoo.fsf@free.fr> (raw)
In-Reply-To: <BD79186B4FD85F4B8E60E381CAEE19090200EA9E@mi8nycmail19.Mi8.com> (H. Hartley Sweeten's message of "Mon\, 14 Dec 2009 18\:05\:02 -0500")
"H Hartley Sweeten" <hartleys@visionengravers.com> writes:
> Use resource_size().
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: David Brownell <dbrownell@users.sourceforge.net>
> Cc: Robert Jarzmik <robert.jarzmik@free.fr>
>
> ---
>
> diff --git a/drivers/usb/gadget/pxa27x_udc.c b/drivers/usb/gadget/pxa27x_udc.c
> index adda120..72c89d9 100644
> --- a/drivers/usb/gadget/pxa27x_udc.c
> +++ b/drivers/usb/gadget/pxa27x_udc.c
> @@ -2439,7 +2439,7 @@ static int __init pxa_udc_probe(struct platform_device *pdev)
> }
>
> retval = -ENOMEM;
> - udc->regs = ioremap(regs->start, regs->end - regs->start + 1);
> + udc->regs = ioremap(regs->start, resource_size(regs));
> if (!udc->regs) {
> dev_err(&pdev->dev, "Unable to map UDC I/O memory\n");
> goto err_map;
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
--
Robert
prev parent reply other threads:[~2009-12-16 20:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-14 23:05 [PATCH] pxa27x_udc.c: use resource_size() H Hartley Sweeten
2009-12-16 20:46 ` Robert Jarzmik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oclytzoo.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=dbrownell@users.sourceforge.net \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox