From: Andi Kleen <andi@firstfloor.org>
To: Pavel Machek <pavel@suse.cz>
Cc: Ingo Molnar <mingo@elte.hu>, kernel list <linux-kernel@vger.kernel.org>
Subject: Re: aperture_64: use symbolic constants
Date: Tue, 20 May 2008 13:20:02 +0200 [thread overview]
Message-ID: <87od71gr31.fsf@basil.nowhere.org> (raw)
In-Reply-To: <20080519123952.GA23118@elf.ucw.cz> (Pavel Machek's message of "Mon, 19 May 2008 14:39:52 +0200")
Pavel Machek <pavel@suse.cz> writes:
> if ((last_aper_order && aper_order != last_aper_order) ||
> @@ -303,9 +303,9 @@ void __init early_gart_iommu_check(void)
> if (!early_is_k8_nb(read_pci_config(0, num, 3, 0x00)))
> continue;
>
> - ctl = read_pci_config(0, num, 3, 0x90);
> + ctl = read_pci_config(0, num, 3, AMD64_GARTAPERTURECTL);
Strictly "AMD64_" is not the correct prefix, because these registers
are generic standard AGP3 registers.
-Andi
next prev parent reply other threads:[~2008-05-20 11:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-19 12:39 aperture_64: use symbolic constants Pavel Machek
2008-05-20 11:20 ` Andi Kleen [this message]
[not found] ` <20080519125425.GD13546@elte.hu>
2008-05-20 14:27 ` Pavel Machek
2008-05-20 15:06 ` Dave Jones
2008-05-20 15:32 ` Pavel Machek
2008-05-20 15:42 ` Dave Jones
2008-05-21 1:23 ` Andi Kleen
2008-05-20 15:42 ` Ingo Molnar
2008-05-21 1:59 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87od71gr31.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox