From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: 7eggert@gmx.de
Cc: Vegard Nossum <vegard.nossum@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] FAT: Fix printk format strings.
Date: Fri, 12 Oct 2007 02:28:52 +0900 [thread overview]
Message-ID: <87odf5h86j.fsf@duaron.myhome.or.jp> (raw)
In-Reply-To: <E1Ifvk1-0000o5-VO@be1.lrz> (Bodo Eggert's message of "Thu\, 11 Oct 2007 12\:58\:09 +0200")
Bodo Eggert <7eggert@gmx.de> writes:
> Vegard Nossum <vegard.nossum@gmail.com> wrote:
>
>> This makes sure printk format strings contain no more than a single
>> line.
>
>> printk(KERN_WARNING
>> - "FAT: Did not find valid FSINFO signature.\n"
>> + "FAT: Did not find valid FSINFO signature.\n");
>> + printk(KERN_WARNING
>> " Found signature1 0x%08x signature2 0x%08x"
>> " (sector = %lu)\n",
>
> What about something like
> "Fat32: Invalid FSINFO signatures 0x%08x, 0x%08x; expected 0x%08x, 0x%08\n" ?
> or
> "Fat32: Invalid FSINFO signatures 0x%08x, 0x%08x\n" ?
Looks good to me. I'll modify a patch, and apply it.
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2007-10-11 17:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <9d2nm-1SV-11@gated-at.bofh.it>
2007-10-11 10:58 ` [PATCH] FAT: Fix printk format strings Bodo Eggert
2007-10-11 17:28 ` OGAWA Hirofumi [this message]
2007-10-11 9:17 Vegard Nossum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87odf5h86j.fsf@duaron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=7eggert@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox