From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A3704963BE
	for <linux-kernel@vger.kernel.org>; Wed, 17 Jun 2026 16:14:39 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1781712891; cv=none; b=g9oAa3IQNVOwA37Sy+JumZbjFpDN+uNgSBqO1hGq4VVJEY7bNXbR82PHON0KEMjkj9OJPmId3M2mH9fnb2PZjAbUKfX1R1g/tO0imOnqs20uFlhpTzihbYL5dKkxpUuyeLswSjOQLdSoks4mNv/KGxp/0tz9b8rnhf+F/qSbksw=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1781712891; c=relaxed/simple;
	bh=PzX57RKpjQ3L1U01cG2bqm4hOwZNOc6obznMl7FeAYg=;
	h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID:
	 MIME-Version:Content-Type; b=UIiVN6IPfFKvv5eEUpMUfBWW80mqmSEB475fqHHbkTTNvPeZ/bCx56VXRM+aoAqwcJl65I1SBmwZ+XENNDMdnw0CD2lWyFZjXHy2M2j3MTkmmFiZIUmtWvDQtWW0V6MXNy+WwoHTKektqsYICofnYvaR8T9fco47ZluAqPhF+xY=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JwkciNjU; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JwkciNjU"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id A32A41F00A3A;
	Wed, 17 Jun 2026 16:14:38 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1781712879;
	bh=4e8PENfpBvartvnzKj6GhJfSVq8A1Ml/Pf0/7rCjlHQ=;
	h=From:To:Cc:Subject:In-Reply-To:References:Date;
	b=JwkciNjUE5eTyNH0A1dnbIqbp3MrNLA8s6187nm9NlzluGatnTb0901kFVmtj9jk0
	 E5AUhyRqrl5rA2xOkitJgffDItMsP2gtC5X7QXmmSZZ7lwTerTzMcZ2RrHUWmO9Phc
	 UCedNESGpR5m2y5cG+WsXSK/jjy/naj4vq4HSYmlHORD4kLVeRXhF1AWZD0XdA+riv
	 PN4AozXetwlThG7TJbenDSk9uWUL+QOWW9IxToKeD9VnRs5vlZ8xFxtIkAGsXHC8Dw
	 NBV9ihKR9oG+0zX2/LTpT8Dy1ryac0hQuNfauzfd28ZN0G27w5qn2xKh7+G9p95ITB
	 fUllRkkdhqKyQ==
From: Thomas Gleixner <tglx@kernel.org>
To: fffsqian@163.com, jhogan@kernel.org
Cc: linux-kernel@vger.kernel.org, Qingshuang Fu <fuqingshuang@kylinos.cn>
Subject: Re: [PATCH 1/1] irqchip/imgpdc: fix generic IRQ chip leak and
 missing chained handler cleanup on remove
In-Reply-To: <20260612084744.1219349-1-fffsqian@163.com>
References: <20260612084744.1219349-1-fffsqian@163.com>
Date: Wed, 17 Jun 2026 18:14:36 +0200
Message-ID: <87pl1pcff7.ffs@fw13>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain

On Fri, Jun 12 2026 at 16:47, fffsqian@163.com wrote:
> @@ -457,6 +457,7 @@ static int pdc_intc_probe(struct platform_device *pdev)
>  
>  	return 0;
>  err_generic:
> +	irq_domain_remove_generic_chips(priv->domain);

You can spare this call and the one below by setting
IRQ_DOMAIN_FLAG_DESTROY_GC in domain->flags. Then the core will remove
the chip when mopping up the domain.

>  	irq_domain_remove(priv->domain);
>  	return ret;
>  }
> @@ -464,7 +465,14 @@ static int pdc_intc_probe(struct platform_device *pdev)
>  static void pdc_intc_remove(struct platform_device *pdev)
>  {
>  	struct pdc_intc_priv *priv = platform_get_drvdata(pdev);
> +	unsigned int i;
> +
> +	for (i = 0; i < priv->nr_perips; ++i)

  for (unsigned int i = 0;

Thanks,

        tglx