From: Takashi Iwai <tiwai@suse.de>
To: "Cássio Gabriel" <cassiogabrielcontato@gmail.com>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: midi2: Restart output URBs on resume
Date: Mon, 04 May 2026 17:55:05 +0200 [thread overview]
Message-ID: <87pl3bw4o6.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260504-usb-midi2-output-resume-v1-1-c089cc8ad3c6@gmail.com>
On Mon, 04 May 2026 16:08:45 +0200,
Cássio Gabriel wrote:
>
> USB MIDI 2.0 suspend saves the endpoint running state, clears it and
> kills all endpoint URBs. Resume restores the running state, but only
> restarts input endpoints.
>
> For a running output endpoint, this leaves the endpoint marked running
> with an empty URB queue. Output transfer progress depends on either the
> rawmidi trigger path starting the queue or an output completion refilling
> it. After suspend there is no completion left, and output data that
> remains queued in the raw UMP or legacy rawmidi buffer can stay stalled
> until userspace happens to trigger the stream again.
>
> Restore the saved state with atomic accessors, keep input endpoints
> restarted as before, and restart output endpoints that were running before
> suspend. Clear the saved suspend state after restoring it.
>
> Fixes: ff49d1df79ae ("ALSA: usb-audio: USB MIDI 2.0 UMP support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Cássio Gabriel <cassiogabrielcontato@gmail.com>
Thanks, applied now.
Takashi
prev parent reply other threads:[~2026-05-04 15:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 14:08 [PATCH] ALSA: usb-audio: midi2: Restart output URBs on resume Cássio Gabriel
2026-05-04 15:55 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pl3bw4o6.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=cassiogabrielcontato@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox