From: Takashi Iwai <tiwai@suse.de>
To: Zhang Heng <zhangheng@kylinos.cn>
Cc: Takashi Iwai <tiwai@suse.de>,
tiwai@suse.com, perex@perex.cz, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for CSL Unity BF24B
Date: Thu, 09 Apr 2026 08:47:24 +0200 [thread overview]
Message-ID: <87pl48k4ub.wl-tiwai@suse.de> (raw)
In-Reply-To: <c5079ef8-abfe-4373-8fc2-7892b23b95d5@kylinos.cn>
On Thu, 09 Apr 2026 08:33:19 +0200,
Zhang Heng wrote:
>
> Some machines also need to write GPIO again after waking up from sleep,
>
> please consider this.
Sure, but your patch puts one extra unnecessary GPIO operation than
needed, and it can be optimized later -- that's my point. The fixup
could deal directly with only GPIO high/low only once. With the
current alc_*_gpio() helpers, the values are cached and it's restored
already once before the fixup at each resume call. So we'd need some
tune up in the helper code for this optimization.
Takashi
>
> 在 2026/4/9 14:30, Takashi Iwai 写道:
> > That said, I'm going to take your patch for now, but we might need to
> > reconsider the implementation of Realtek codec helpers about GPIO
> > handling.
> >
next prev parent reply other threads:[~2026-04-09 6:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 2:40 [PATCH] ALSA: hda/realtek: Add quirk for CSL Unity BF24B Zhang Heng
2026-04-09 5:09 ` Takashi Iwai
2026-04-09 5:58 ` Zhang Heng
2026-04-09 6:28 ` Takashi Iwai
2026-04-09 6:30 ` Takashi Iwai
2026-04-09 6:33 ` Zhang Heng
2026-04-09 6:47 ` Takashi Iwai [this message]
2026-04-09 7:00 ` Zhang Heng
2026-04-09 7:24 ` Takashi Iwai
2026-04-09 7:51 ` Zhang Heng
2026-04-09 7:59 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pl48k4ub.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=zhangheng@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox