The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: kernel test robot <lkp@intel.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
	x86@kernel.org
Subject: Re: [tip:x86/urgent 2/2] irq.c:undefined reference to `lock_vector_lock'
Date: Sat, 02 Aug 2025 21:58:34 +0200	[thread overview]
Message-ID: <87plddh4wl.ffs@tglx> (raw)
In-Reply-To: <202508022015.ZX6l8pZr-lkp@intel.com>

On Sat, Aug 02 2025 at 20:02, kernel test robot wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/urgent
> head:   69adc077da4c247dd39a8a0e3a898a25924e98d0
> commit: 69adc077da4c247dd39a8a0e3a898a25924e98d0 [2/2] x86/irq: Plug vector setup race
> config: i386-buildonly-randconfig-2002-20250802 (https://download.01.org/0day-ci/archive/20250802/202508022015.ZX6l8pZr-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250802/202508022015.ZX6l8pZr-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202508022015.ZX6l8pZr-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
>    ld: arch/x86/kernel/irq.o: in function `__common_interrupt':
>>> irq.c:(.text+0x4f): undefined reference to `lock_vector_lock'
>>> ld: irq.c:(.text+0x73): undefined reference to `unlock_vector_lock'
>    ld: irq.c:(.text+0xa8): undefined reference to `unlock_vector_lock'
>    ld: irq.c:(.text+0xc5): undefined reference to `unlock_vector_lock'

Bah. The config guard in hw_irq.h is bogus. It's equally bogus as the
whole APIC=n legacy which we still carry around for no good reason.

I've amended the commit and force pushed the branch...

      reply	other threads:[~2025-08-02 19:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-02 18:02 [tip:x86/urgent 2/2] irq.c:undefined reference to `lock_vector_lock' kernel test robot
2025-08-02 19:58 ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87plddh4wl.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox