From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D9E164A8F; Fri, 18 Apr 2025 15:35:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744990518; cv=none; b=RAg6N7ih6IKx6vfRpOYvu+DcjD4uXFseaULoqWAoGsR9tj2etso5aLh5egtuaCN9slROzqV9BVxq7/+XjSr7o09RLy2vPKw0pVvaRGDRQ6xE9ULvi3XkHRDhxZgaezate51oE8Z+2AuATtUQhhHQuuhyDk0rlY+yGz/O6oE5ayM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744990518; c=relaxed/simple; bh=7NHab62RZtPj0Np+h3D9F3dxP/sVC+/JnFk6D/PUpPQ=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=EqJWLVqMyojI56Edhdj1Q0F9+7wa6xJhIEGM0I6nzrdoH3oKAPkCOB1RQm4ZB/8uGxpDUv8AcA5qpJM3zq8Ayx0ujDzIorqEnN7iZjKoDz4ZOnbGfq5u0rb87+itnUO9xPb8x4T1H5OBrkU+bBwhthBtY0P1rzqSlu5MWTcXF08= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uqzjTsEn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uqzjTsEn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1863CC4CEEA; Fri, 18 Apr 2025 15:35:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744990518; bh=7NHab62RZtPj0Np+h3D9F3dxP/sVC+/JnFk6D/PUpPQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uqzjTsEnt9rDe+ksBBlT3BLXDvD6oHj/oGnFMl4wzPOE/y7OsfkdibxQnus0m3BAT +Z2qaFSGhZq07whzJPZjt5WArxUXWXyOeLky4XMAa6ay+xm5WOX/17eKfxr4cxsuEX JaJTxU+shymgO6NAmDcbCDNuZZparjTo6TcQRUt+Sb6pylRsSYd1lK97CI4B93LuVb 3wxLctZljW/x2jALr2c/dFwan9BRHFdFT+eNLM/5Uv+63xjEL/CVdzt4hRIOCvcGvi 7ZeABxWyYURO/vSJMWJE1tAx4ebji6fO4/FNg7uqS7KtaVU7TgmWnY3r2xP107RcjZ kJ8+DBdQdreQA== Received: from sofa.misterjones.org ([185.219.108.64] helo=lobster-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1u5nkJ-006krU-QT; Fri, 18 Apr 2025 16:35:15 +0100 Date: Fri, 18 Apr 2025 16:35:22 +0100 Message-ID: <87plh9xz2d.wl-maz@kernel.org> From: Marc Zyngier To: Yury Norov Cc: Andrew Lunn , Luo Jie , Rasmus Villemoes , Julia Lawall , Nicolas Palix , Catalin Marinas , Will Deacon , Oliver Upton , Joey Gouly , Suzuki K Poulose , Zenghui Yu , linux-kernel@vger.kernel.org, cocci@inria.fr, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, quic_kkumarcs@quicinc.com, quic_linchen@quicinc.com, quic_leiwei@quicinc.com, quic_suruchia@quicinc.com, quic_pavir@quicinc.com Subject: Re: [PATCH v3 0/6] Add FIELD_MODIFY() helper In-Reply-To: References: <20250417-field_modify-v3-0-6f7992aafcb7@quicinc.com> <86sem7jb5t.wl-maz@kernel.org> <0c97c659-bd28-45e0-8537-d9be2637cb22@lunn.ch> <86mscek7h3.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: yury.norov@gmail.com, andrew@lunn.ch, quic_luoj@quicinc.com, linux@rasmusvillemoes.dk, Julia.Lawall@inria.fr, nicolas.palix@imag.fr, catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, linux-kernel@vger.kernel.org, cocci@inria.fr, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, quic_kkumarcs@quicinc.com, quic_linchen@quicinc.com, quic_leiwei@quicinc.com, quic_suruchia@quicinc.com, quic_pavir@quicinc.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Fri, 18 Apr 2025 16:08:38 +0100, Yury Norov wrote: > > On Thu, Apr 17, 2025 at 06:45:12PM +0100, Marc Zyngier wrote: > > On Thu, 17 Apr 2025 18:22:29 +0100, > > Andrew Lunn wrote: > > > > > > On Thu, Apr 17, 2025 at 12:10:54PM +0100, Marc Zyngier wrote: > > > > On Thu, 17 Apr 2025 11:47:07 +0100, > > > > Luo Jie wrote: > > > > > > > > > > Add the helper FIELD_MODIFY() to the FIELD_XXX family of bitfield > > > > > macros. It is functionally similar as xxx_replace_bits(), but adds > > > > > the compile time checking to catch incorrect parameter type errors. > > > > > > > > > > This series also converts the four instances of opencoded FIELD_MODIFY() > > > > > that are found in the core kernel files, to instead use the new > > > > > FIELD_MODIFY() macro. This is achieved with Coccinelle, by adding > > > > > the script field_modify.cocci. > > > > > > > > > > The changes are validated on IPQ9574 SoC which uses ARM64 architecture. > > > > > > > > We already have the *_replace_bits() functions (see > > > > include/linux/bitfield.h). > > > > > > > > Why do we need extra helpers? > > > > > > If you look at bitfield.h, the *_replace_bits() seem to be > > > undocumented internal macro magic, not something you are expected to > > > use. What you are expected to use in that file is however well > > > documented. The macro magic also means that cross referencing tools > > > don't find them. > > > > $ git grep _replace_bits| wc -l > > 1514 > > FIELD_PREP() only is used 10 times more. And? I'm sure that if you count "+", you'll find it to be yet a few order of magnitudes more. > > > I think a bunch of people have found them, tooling notwithstanding. > > > > As for the documentation, the commit message in 00b0c9b82663ac would > > be advantageously promoted to full-fledged kernel-doc. > > The FIELD_MODIFY() and uxx_replace_bits() are simply different things. > > FIELD_MODIFY() employs __BF_FIELD_CHECK(), which allows strict > parameters checking at compile time. And people like it. See > recent fixed-size GENMASK() series: > > https://patchwork.kernel.org/comment/26283604/ I don't care much for what people like or not. I don't see this FIELD_MODIFY() as a particular improvement on *_replace_bits(). > The _replace_bits() functions return fixed-width values, and intended > for: "manipulating bitfields both in host- and fixed-endian", as the > very first line in the commit message says. > > Those using _replace_bits() for something else abuse the API, and > should switch to FIELD_MODIFY(). Or not. M. -- Jazz isn't dead. It just smells funny.