[PATCH v2] genirq: Fix parameter type in declaration and definition

[PATCH v2] genirq: Fix parameter type in declaration and definition

[ye.xingchen]

From: YeXingchen <ye.xingchen@zte.com.cn>

The declaration of irq_set_irqchip_state in the header file uses
bool state as the parameter type, while the definition uses bool val.

This patch aligns the parameter name in the definition with the
declaration,changing val to state to ensure consistency.

Signed-off-by: YeXingchen <ye.xingchen@zte.com.cn>
---
 kernel/irq/manage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index f300bb6be3bd..fc44c2df8d01 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -2860,7 +2860,7 @@ EXPORT_SYMBOL_GPL(irq_get_irqchip_state);
  *	interrupt controller has per-cpu registers.
  */
 int irq_set_irqchip_state(unsigned int irq, enum irqchip_irq_state which,
-			  bool val)
+			  bool state)
 {
 	struct irq_desc *desc;
 	struct irq_data *data;
-- 
2.25.1

Re: [PATCH v2] genirq: Fix parameter type in declaration and definition

[Thomas Gleixner]

On Thu, Mar 13 2025 at 15:30, ye xingchen wrote:
> From: YeXingchen <ye.xingchen@zte.com.cn>
>
> The declaration of irq_set_irqchip_state in the header file uses
> bool state as the parameter type, while the definition uses bool val.

What's the problem?

> This patch aligns the parameter name in the definition with the

git grep 'This patch' Documentation/process/

> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -2860,7 +2860,7 @@ EXPORT_SYMBOL_GPL(irq_get_irqchip_state);
>   *	interrupt controller has per-cpu registers.
>   */
>  int irq_set_irqchip_state(unsigned int irq, enum irqchip_irq_state which,
> -			  bool val)
> +			  bool state)
>  {
>  	struct irq_desc *desc;
>  	struct irq_data *data;

This does not even compile....

So that clearly ensures consistency...