From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Petr Pavlu <petr.pavlu@suse.com>
Cc: Shyam Saini <shyamsaini@linux.microsoft.com>,
linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org,
code@tyhicks.com, christophe.leroy@csgroup.eu,
hch@infradead.org, mcgrof@kernel.org,
frkaya@linux.microsoft.com, vijayb@linux.microsoft.com,
linux@weissschuh.net, samitolvanen@google.com,
da.gomez@samsung.com, gregkh@linuxfoundation.org,
rafael@kernel.org, dakr@kernel.org
Subject: Re: [PATCH v3 3/4] kernel: globalize lookup_or_create_module_kobject()
Date: Fri, 21 Feb 2025 11:48:19 +0100 [thread overview]
Message-ID: <87pljbo9os.fsf@prevas.dk> (raw)
In-Reply-To: <450e8088-c239-4738-a996-834734f770a5@suse.com> (Petr Pavlu's message of "Thu, 13 Feb 2025 16:59:25 +0100")
On Thu, Feb 13 2025, Petr Pavlu <petr.pavlu@suse.com> wrote:
> On 2/11/25 22:48, Shyam Saini wrote:
>> lookup_or_create_module_kobject() is marked as static and __init,
>> to make it global drop static keyword.
>> Since this function can be called from non-init code, use __modinit
>> instead of __init, __modinit marker will make it __init if
>> CONFIG_MODULES is not defined.
>
> Hm, we should later clean up kernel/params.c to use __init_or_module
> from include/linux/module.h instead of its own __modinit implementation.
Good catch, yes. Mind sending the patch?
Rasmus
next prev parent reply other threads:[~2025-02-21 10:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 21:48 [PATCH v3 0/4] Properly handle module_kobject creation Shyam Saini
2025-02-11 21:48 ` [PATCH v3 1/4] kernel: param: rename locate_module_kobject Shyam Saini
2025-02-13 15:57 ` Petr Pavlu
2025-02-11 21:48 ` [PATCH v3 2/4] kernel: refactor lookup_or_create_module_kobject() Shyam Saini
2025-02-13 15:55 ` Petr Pavlu
2025-02-21 10:42 ` Rasmus Villemoes
2025-02-25 8:33 ` Petr Pavlu
2025-02-25 17:24 ` Shyam Saini
2025-02-27 13:08 ` Petr Pavlu
2025-02-11 21:48 ` [PATCH v3 3/4] kernel: globalize lookup_or_create_module_kobject() Shyam Saini
2025-02-13 15:59 ` Petr Pavlu
2025-02-21 10:48 ` Rasmus Villemoes [this message]
2025-02-11 21:48 ` [PATCH v3 4/4] drivers: base: handle module_kobject creation Shyam Saini
2025-02-20 12:01 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pljbo9os.fsf@prevas.dk \
--to=linux@rasmusvillemoes.dk \
--cc=christophe.leroy@csgroup.eu \
--cc=code@tyhicks.com \
--cc=da.gomez@samsung.com \
--cc=dakr@kernel.org \
--cc=frkaya@linux.microsoft.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=mcgrof@kernel.org \
--cc=petr.pavlu@suse.com \
--cc=rafael@kernel.org \
--cc=samitolvanen@google.com \
--cc=shyamsaini@linux.microsoft.com \
--cc=vijayb@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox