From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Frank Li <Frank.Li@nxp.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Carlos Song <carlos.song@nxp.com>,
linux-i3c@lists.infradead.org (moderated list:I3C SUBSYSTEM),
linux-kernel@vger.kernel.org (open list),
imx@lists.linux.dev
Subject: Re: [PATCH 1/1] i3c: master: Fix missing 'ret' assignment in set_speed()
Date: Thu, 09 Jan 2025 14:04:44 +0100 [thread overview]
Message-ID: <87plkwcf4j.fsf@bootlin.com> (raw)
In-Reply-To: <20250108225533.915334-1-Frank.Li@nxp.com> (Frank Li's message of "Wed, 8 Jan 2025 17:55:33 -0500")
On 08/01/2025 at 17:55:33 -05, Frank Li <Frank.Li@nxp.com> wrote:
> Fix a probe failure in the i3c master driver that occurs when no i3c
> devices are connected to the bus.
>
> The issue arises in `i3c_master_bus_init()` where the `ret` value is not
> updated after calling `master->ops->set_speed()`. If no devices are
> present, `ret` remains set to `I3C_ERROR_M2`, causing the code to
> incorrectly proceed to `err_bus_cleanup`.
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Thanks,
Miquèl
next prev parent reply other threads:[~2025-01-09 13:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 22:55 [PATCH 1/1] i3c: master: Fix missing 'ret' assignment in set_speed() Frank Li
2025-01-09 7:43 ` Wolfram Sang
2025-01-09 8:50 ` Mukesh Kumar Savaliya
2025-01-09 13:04 ` Miquel Raynal [this message]
2025-01-12 23:04 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plkwcf4j.fsf@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=Frank.Li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=carlos.song@nxp.com \
--cc=imx@lists.linux.dev \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox