Re: [PATCH v12 2/2] rust: xarray: Add an abstraction for XArray

Tamir Duberstein
2024-12-13T19:48:27Z

On Fri, Dec 13, 2024 at 2:38 PM Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
> Personally, I would rewrite at least the `if` one, since it is not
> really how we write those elsewhere. The other one, since you are
> building an iterator anyway, I think it makes sense. For similar
> reasons, perhaps one `match` you have could be an early return
> instead.

I'll make these changes.

> But it is up to the maintainer. By the way, I don't see the XARRAY
> maintainer nor the list Cc'd?

Oops, this was an unintended omission. I'll resend this and include those folks.