Re: [PATCH v12 2/2] rust: xarray: Add an abstraction for XArray

Miguel Ojeda
2024-12-13T17:23:20Z

On Fri, Dec 13, 2024 at 5:25 PM Tamir Duberstein <tamird@gmail.com> wrote:
>
> That's a fair assessment, but it's a subjective area -- Andreas was
> fond of the approach (in a preview review).

Some things are subjective, yet we pick particular options and have guidelines.

I think we should generally refrain ourselves from making code
non-obvious for others that are still learning Rust and its standard
library, unless there is an actual advantage writing the code a
particular way.

Over time, when more kernel developers are somewhat familiar with
Rust, then sure. This is also how other features in kernel C have been
introduced.

Cheers,
Miguel