* [PATCH] fat: use nls_tolower simplify code
@ 2024-11-28 3:12 Wang Jianjian
2024-11-28 4:52 ` OGAWA Hirofumi
2024-11-28 16:55 ` Markus Elfring
0 siblings, 2 replies; 3+ messages in thread
From: Wang Jianjian @ 2024-11-28 3:12 UTC (permalink / raw)
To: OGAWA Hirofumi, linux-kernel; +Cc: wangjianjian0, Wang Jianjian
Signed-off-by: Wang Jianjian <wangjianjian3@huawei.com>
---
fs/fat/dir.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/fs/fat/dir.c b/fs/fat/dir.c
index acbec5bdd521..88bf16204aab 100644
--- a/fs/fat/dir.c
+++ b/fs/fat/dir.c
@@ -214,10 +214,7 @@ fat_short2lower_uni(struct nls_table *t, unsigned char *c,
*uni = 0x003f; /* a question mark */
charlen = 1;
} else if (charlen <= 1) {
- unsigned char nc = t->charset2lower[*c];
-
- if (!nc)
- nc = *c;
+ unsigned char nc = nls_tolower(t, *c);
charlen = t->char2uni(&nc, 1, uni);
if (charlen < 0) {
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fat: use nls_tolower simplify code
2024-11-28 3:12 [PATCH] fat: use nls_tolower simplify code Wang Jianjian
@ 2024-11-28 4:52 ` OGAWA Hirofumi
2024-11-28 16:55 ` Markus Elfring
1 sibling, 0 replies; 3+ messages in thread
From: OGAWA Hirofumi @ 2024-11-28 4:52 UTC (permalink / raw)
To: Andrew Morton; +Cc: Wang Jianjian, linux-kernel, wangjianjian0
Wang Jianjian <wangjianjian3@huawei.com> writes:
> Signed-off-by: Wang Jianjian <wangjianjian3@huawei.com>
Looks good. Thanks.
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
> ---
> fs/fat/dir.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/fs/fat/dir.c b/fs/fat/dir.c
> index acbec5bdd521..88bf16204aab 100644
> --- a/fs/fat/dir.c
> +++ b/fs/fat/dir.c
> @@ -214,10 +214,7 @@ fat_short2lower_uni(struct nls_table *t, unsigned char *c,
> *uni = 0x003f; /* a question mark */
> charlen = 1;
> } else if (charlen <= 1) {
> - unsigned char nc = t->charset2lower[*c];
> -
> - if (!nc)
> - nc = *c;
> + unsigned char nc = nls_tolower(t, *c);
>
> charlen = t->char2uni(&nc, 1, uni);
> if (charlen < 0) {
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fat: use nls_tolower simplify code
2024-11-28 3:12 [PATCH] fat: use nls_tolower simplify code Wang Jianjian
2024-11-28 4:52 ` OGAWA Hirofumi
@ 2024-11-28 16:55 ` Markus Elfring
1 sibling, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2024-11-28 16:55 UTC (permalink / raw)
To: Wang Jianjian, Ogawa Hirofumi; +Cc: Wang Jianjian, LKML, kernel-janitors
Will another change description be helpful?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12#n45
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-11-28 16:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-28 3:12 [PATCH] fat: use nls_tolower simplify code Wang Jianjian
2024-11-28 4:52 ` OGAWA Hirofumi
2024-11-28 16:55 ` Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox