From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAA5820B1F4 for ; Fri, 11 Oct 2024 09:08:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728637695; cv=none; b=gSaZwLNIIk3bffZPNSH66iQ5nkGWQDq7Vw5R/6qnvTR/fdi0CJpmdsViKL3AwKVP+GPbJVRbblx3wpbBV8UePoTjDXtQcAbBALRztbHDBO3E74cJ+K7aoOa+tj/NQMduVKAUipPn53MM5Y4e/5kxUZOzdLNknlRprXeL6vUD/YI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728637695; c=relaxed/simple; bh=RQ7Lxb9941hJIWIjknEb0KZH3t22jRdOrvwNUZ7gKEc=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=ACrMfUCf+14uwGc8cPMgCyBz4AyJ1BHHqRNKRsOlzZm/nkRXLIITnkS7Gc9YUitGa1lYXBXD9ualdVkXt6xodpiHVb0VepiXzlgSaPAqmgmeJj0DgOpNxFfgh4IsOaosNHClYwa2/3ETQ1TCXvM1Wr27R4az8HyZRrfd+LASr2g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=1U+EnOyh; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=RcgRk04j; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=1U+EnOyh; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=RcgRk04j; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="1U+EnOyh"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="RcgRk04j"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="1U+EnOyh"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="RcgRk04j" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B1A3422006; Fri, 11 Oct 2024 09:08:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1728637691; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qRtkyU1XwOFtiE9AeGs8BXfcw5siT/eDeiiVg8cjBIE=; b=1U+EnOyhpEaNx7NrHFLfdshoEkclnxLJ3ZqISbCoioJE516o2kiXE51TZHXOmB+U/NokQA Q2fa7Z8cDWq+flVN8myQ+7GThNR7QKGCBcJ+cG+7nL76DYOML2hqLDsCCkuyAJ3dscEAoo SzxDqc6w4YWgBNr4fp4JuA1EjbExHT4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1728637691; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qRtkyU1XwOFtiE9AeGs8BXfcw5siT/eDeiiVg8cjBIE=; b=RcgRk04jXRDLFa3PIdIWkxQxQOB8++W6+LtLBXZjxqtmVlP046MMyrgicMykMPp5XRXgaN mtY4i/I6LjQZs2Bw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=1U+EnOyh; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=RcgRk04j DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1728637691; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qRtkyU1XwOFtiE9AeGs8BXfcw5siT/eDeiiVg8cjBIE=; b=1U+EnOyhpEaNx7NrHFLfdshoEkclnxLJ3ZqISbCoioJE516o2kiXE51TZHXOmB+U/NokQA Q2fa7Z8cDWq+flVN8myQ+7GThNR7QKGCBcJ+cG+7nL76DYOML2hqLDsCCkuyAJ3dscEAoo SzxDqc6w4YWgBNr4fp4JuA1EjbExHT4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1728637691; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qRtkyU1XwOFtiE9AeGs8BXfcw5siT/eDeiiVg8cjBIE=; b=RcgRk04jXRDLFa3PIdIWkxQxQOB8++W6+LtLBXZjxqtmVlP046MMyrgicMykMPp5XRXgaN mtY4i/I6LjQZs2Bw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3BE5D136E0; Fri, 11 Oct 2024 09:08:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id K8V5DfvqCGdsKAAAD6G6ig (envelope-from ); Fri, 11 Oct 2024 09:08:11 +0000 Date: Fri, 11 Oct 2024 11:09:08 +0200 Message-ID: <87plo7m2ff.wl-tiwai@suse.de> From: Takashi Iwai To: Baojun Xu Cc: , , , , , , , , <13916275206@139.com>, , , , , , , , , Subject: Re: [PATCH v1] ALSA: hda/tas2781: Add speaker id check for ASUS projects In-Reply-To: <20241011085303.738-1-baojun.xu@ti.com> References: <20241011085303.738-1-baojun.xu@ti.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: B1A3422006 X-Spam-Score: -2.01 X-Rspamd-Action: no action X-Spamd-Result: default: False [-2.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FUZZY_BLOCKED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCPT_COUNT_TWELVE(0.00)[19]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FREEMAIL_ENVRCPT(0.00)[139.com,gmail.com]; FREEMAIL_CC(0.00)[kernel.org,linux.intel.com,gmail.com,perex.cz,ti.com,139.com,alsa-project.org,vger.kernel.org,intel.com,irl.hu]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_VIA_SMTP_AUTH(0.00)[]; TAGGED_RCPT(0.00)[dt]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.de:dkim] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Flag: NO X-Spam-Level: On Fri, 11 Oct 2024 10:53:03 +0200, Baojun Xu wrote: > > Add speaker id check by gpio in ACPI for ASUS projects. Please give more background info. e.g. why is the speaker id check needed, what does this patch actually fix, and why it's specific to ASUS? thanks, Takashi > > Signed-off-by: Baojun Xu > --- > include/sound/tas2781.h | 3 +++ > sound/pci/hda/tas2781_hda_i2c.c | 39 ++++++++++++++++++++++++++++++--- > 2 files changed, 39 insertions(+), 3 deletions(-) > > diff --git a/include/sound/tas2781.h b/include/sound/tas2781.h > index 8cd6da0480b7..f8a3dc13cbbc 100644 > --- a/include/sound/tas2781.h > +++ b/include/sound/tas2781.h > @@ -107,6 +107,8 @@ > #define TASDEVICE_CMD_DELAY 0x3 > #define TASDEVICE_CMD_FIELD_W 0x4 > > +#define TAS2781_ASUS_ID 0x10430000 > + > enum audio_device { > TAS2563, > TAS2781, > @@ -156,6 +158,7 @@ struct tasdevice_priv { > struct tasdevice_rca rcabin; > struct calidata cali_data; > struct tasdevice_fw *fmw; > + struct gpio_desc *speaker_id; > struct gpio_desc *reset; > struct mutex codec_lock; > struct regmap *regmap; > diff --git a/sound/pci/hda/tas2781_hda_i2c.c b/sound/pci/hda/tas2781_hda_i2c.c > index 370d847517f9..1f71927825b2 100644 > --- a/sound/pci/hda/tas2781_hda_i2c.c > +++ b/sound/pci/hda/tas2781_hda_i2c.c > @@ -615,7 +615,7 @@ static void tasdev_fw_ready(const struct firmware *fmw, void *context) > struct tasdevice_priv *tas_priv = context; > struct tas2781_hda *tas_hda = dev_get_drvdata(tas_priv->dev); > struct hda_codec *codec = tas_priv->codec; > - int i, ret; > + int i, ret, spk_id; > > pm_runtime_get_sync(tas_priv->dev); > mutex_lock(&tas_priv->codec_lock); > @@ -648,8 +648,23 @@ static void tasdev_fw_ready(const struct firmware *fmw, void *context) > tasdevice_dsp_remove(tas_priv); > > tas_priv->fw_state = TASDEVICE_DSP_FW_PENDING; > - scnprintf(tas_priv->coef_binaryname, 64, "TAS2XXX%04X.bin", > - codec->core.subsystem_id & 0xffff); > + if ((codec->core.subsystem_id & 0xffff0000) == TAS2781_ASUS_ID) { > + // Speaker id need to be checked. > + if (tas_priv->speaker_id) > + spk_id = gpiod_get_value(tas_priv->speaker_id); > + else > + spk_id = 0; > + if (spk_id < 0 || spk_id > 1) { > + // Speaker id is not valid, use default. > + dev_dbg(tas_priv->dev, "Wrong spk_id = %d\n", spk_id); > + spk_id = 0; > + } > + scnprintf(tas_priv->coef_binaryname, 64, "TAS2XXX%04X%01d.bin", > + codec->core.subsystem_id & 0xffff, spk_id); > + } else { > + scnprintf(tas_priv->coef_binaryname, 64, "TAS2XXX%04X.bin", > + codec->core.subsystem_id & 0xffff); > + } > ret = tasdevice_dsp_parser(tas_priv); > if (ret) { > dev_err(tas_priv->dev, "dspfw load %s error\n", > @@ -787,6 +802,15 @@ static void tas2781_hda_remove(struct device *dev) > tasdevice_remove(tas_hda->priv); > } > > +static const struct acpi_gpio_params speakerid_gpios = { 0, 0, false }; > +static const struct acpi_gpio_params interrupt_gpios = { 1, 0, false }; > + > +static const struct acpi_gpio_mapping tas2781_speaker_id_gpios[] = { > + { "speakerid-gpios", &speakerid_gpios, 1 }, > + { "interrupt-gpios", &interrupt_gpios, 1 }, > + { } > +}; > + > static int tas2781_hda_i2c_probe(struct i2c_client *clt) > { > struct tas2781_hda *tas_hda; > @@ -823,6 +847,15 @@ static int tas2781_hda_i2c_probe(struct i2c_client *clt) > if (ret) > return dev_err_probe(tas_hda->dev, ret, > "Platform not supported\n"); > + ret = devm_acpi_dev_add_driver_gpios(tas_hda->dev, > + tas2781_speaker_id_gpios); > + if (ret) > + dev_info(tas_hda->dev, "Unable to add GPIO mapping table\n"); > + > + tas_hda->priv->speaker_id = devm_gpiod_get(tas_hda->dev, "speakerid", > + GPIOD_IN); > + if (IS_ERR(tas_hda->priv->speaker_id)) > + dev_info(tas_hda->dev, "Failed to get Speaker id gpio.\n"); > > ret = tasdevice_init(tas_hda->priv); > if (ret) > -- > 2.43.0 >