From: Thomas Gleixner <tglx@linutronix.de>
To: Kevin Chen <kevin_chen@aspeedtech.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
joel@jms.id.au, andrew@codeconstruct.com.au,
kevin_chen@aspeedtech.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org
Subject: Re: [PATCH v2 2/2] irqchip/aspeed-intc: Add support for AST27XX INTC
Date: Wed, 14 Aug 2024 17:06:14 +0200 [thread overview]
Message-ID: <87plqbnnyx.ffs@tglx> (raw)
In-Reply-To: <20240814114106.2809876-4-kevin_chen@aspeedtech.com>
On Wed, Aug 14 2024 at 19:41, Kevin Chen wrote:
> Support for the Aspeed Interrupt Controller found on Aspeed Silicon SoCs,
> such as the AST2700, which is arm64 architecture.
>
> To support ASPEED interrupt controller(INTC) maps the internal interrupt
> sources of the AST27XX device to an parent interrupt controller.
This still lacks a Signed-off-by: tag and my comment about the error
path in the init function is still valid.
Do you think that addressing review feedback is optional?
Feel free to ignore it, but don't be surprised if I ignore further
patches from you.
Take your time and go through stuff properly and do not rush out half
baked patches in a frenzy.
Thanks,
tglx
next prev parent reply other threads:[~2024-08-14 15:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 11:41 [PATCH v1 0/2] Add support for AST2700 INTC driver Kevin Chen
2024-08-14 11:41 ` [PATCH v2 0/2] Add support for AST2700 INTC Kevin Chen
2024-08-14 15:14 ` Krzysztof Kozlowski
2024-08-14 11:41 ` [PATCH v2 1/2] dt-bindings: interrupt-controller: Add support for ASPEED AST27XX INTC Kevin Chen
2024-08-14 14:04 ` Krzysztof Kozlowski
2024-10-07 10:48 ` Kevin Chen
2024-08-18 15:20 ` Rob Herring
2024-08-14 11:41 ` [PATCH v2 2/2] irqchip/aspeed-intc: Add support for " Kevin Chen
2024-08-14 14:06 ` Krzysztof Kozlowski
2024-10-07 10:48 ` Kevin Chen
2024-08-14 15:06 ` Thomas Gleixner [this message]
2024-08-14 15:11 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plqbnnyx.ffs@tglx \
--to=tglx@linutronix.de \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=kevin_chen@aspeedtech.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox