Re: [PATCH] memory: fsl_ifc: Make FSL_IFC config visible and selectable

Krzysztof Kozlowski
2024-05-28T06:53:30Z

On 27/05/2024 09:47, Esben Haabendal wrote:
>
> Ok, I seem to still be confused as to what you want from me. If you are
> saying that the kernel is not supposed to care about out-of-tree DTS
> (and thereby any bootloader provided DTB), I would like to bring your
> attention to arch/arm/boot/dts/nxp/ls/ls1021a-twr.dts in upstream:
>
> &ifc {
> #address-cells = <2>;
> #size-cells = <1>;
> /* NOR Flash on board */
> ranges = <0x0 0x0 0x0 0x60000000 0x08000000>;
> status = "okay";
>
> nor@0,0 {
> #address-cells = <1>;
> #size-cells = <1>;
> compatible = "cfi-flash";
> reg = <0x0 0x0 0x8000000>;
> big-endian;
> bank-width = <2>;
> device-width = <1>;
> };
> };
>

I don't understand why it took so many emails to answer that (my first)
question... Sounds good, however you did not update the existing select.
Drivers are not supposed to select user-visible symbols (leads to
issues), so you need to change it to depends and update defconfigs.

Best regards,
Krzysztof