From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36A4417F394
	for <linux-kernel@vger.kernel.org>; Tue, 14 May 2024 17:23:38 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1715707420; cv=none; b=rcsUQ4v56dnuREKpk+6ZlIcuYb4UaovbCYVxcEbC4bMoGlg3cRLzgSPqqGeS70CibM957WrdFxFxfbM6zpvUr55ak19Id8wXyYPuQlAXB9dj1GfqovjzLE9V6GKdxpVNg5deoBqUbZAB2C/LpkEpGtF/PKUaZwchxh8obJYAneU=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1715707420; c=relaxed/simple;
	bh=pJlUi+KXkei8lg6ra/Ca1kaBmxiwkdtHHBcOwgmpYNw=;
	h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID:
	 MIME-Version:Content-Type; b=FX3rU2QX84yLfww8cXjUjjZxGyHxq8dYrbPKe+n1+p2gCbYdXEPOoTUkycOyi44ffo1OQocdGJDzLz6UY64BCwfs6yEUYl0QZ35FxDFLaWNdelYHj5bOVfudwCWhX1ZEzDR+hyCSm4AvLIFpxvnFMUFjqYnHtqtTPhi0+k6oZNc=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=u//H3XAF; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=NYUd2FyO; arc=none smtp.client-ip=193.142.43.55
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="u//H3XAF";
	dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="NYUd2FyO"
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1715707417;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=6G6DQyPhwSC91Uzzzi51uTfYXPdGZ8cCXSYSci/EkjA=;
	b=u//H3XAF0bDpgKAq5YmtDErhqrHoq0magXqS2ITQJbedoZntfr20eM0d9IssJ+TxKKu4xO
	EOeVUdhkHXgMaQqFtQQzhOPAJ3AKy3x8v8oBLZbMVRNhvZ4agQixzb9s43nsW66m+Q69Tv
	gNFUN4jvIRjK7Jc5Od6AYNYSxBW+KmZofFhieneFOeB+clu/7Fxe57UCueuWWjTW9qZOzH
	QRSzQGWEMQ+tIJWfwQNTUaDrxGUs3Re7m+ytSTuAK5kOeiB5FIo5tyhGjywW7kxqiY46MS
	gR4+6bhunpmTbwHJB3Ko/2FHwPmVfmFnWZ52aVLreIbgXw4iH4UZZG73itXCaQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1715707417;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=6G6DQyPhwSC91Uzzzi51uTfYXPdGZ8cCXSYSci/EkjA=;
	b=NYUd2FyOqm1bSC8UdWvEtly0qoG+IbTEQri9l0rM4LUUy6vDdsz2z7iqvruzjfMdyanqbC
	mLaqVtVsG+UbcpBw==
To: Jinjie Ruan <ruanjinjie@huawei.com>, linux-kernel@vger.kernel.org
Cc: ruanjinjie@huawei.com
Subject: Re: [PATCH] genirq: Refactor the irq_chip_xxx_parent()
In-Reply-To: <20240514131910.2614027-1-ruanjinjie@huawei.com>
References: <20240514131910.2614027-1-ruanjinjie@huawei.com>
Date: Tue, 14 May 2024 19:23:37 +0200
Message-ID: <87pltol33a.ffs@tglx>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain

On Tue, May 14 2024 at 21:19, Jinjie Ruan wrote:
> +static inline void irq_chip_do_common_parent(void (*chip_action)(struct irq_data *),
> +					     struct irq_data *data)
> +{
> +	data = data->parent_data;
> +	chip_action(data);
> +}

>  void irq_chip_eoi_parent(struct irq_data *data)
>  {
> -	data = data->parent_data;
> -	data->chip->irq_eoi(data);
> +	irq_chip_do_common_parent(data->chip->irq_eoi, data);
>  }
>  EXPORT_SYMBOL_GPL(irq_chip_eoi_parent);

How is this equivalent?

The original code does:

    data = data->parent_data;
    data->chip->irq_eoi(data);

which is equivalent to:

    data->parent_data->chip->irq_eoi(data->parent_data);

while your change resolves to:

    data->chip->irq_eoi(data->parent_data);

Seriously?

I'm starting to get tired of your flood of half baken 'cleanup' patches.

Thanks,

        tglx